From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967341AbeCAJ7Q (ORCPT ); Thu, 1 Mar 2018 04:59:16 -0500 Received: from kirsty.vergenet.net ([202.4.237.240]:56549 "EHLO kirsty.vergenet.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967148AbeCAJ7O (ORCPT ); Thu, 1 Mar 2018 04:59:14 -0500 Date: Thu, 1 Mar 2018 10:59:09 +0100 From: Simon Horman To: Arnd Bergmann Cc: Jacopo Mondi , Mauro Carvalho Chehab , Miguel Ojeda , Hans Verkuil , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: renesas-ceu: mark PM functions as __maybe_unused Message-ID: <20180301095909.of6irggy4bke6dmx@verge.net.au> References: <20180228231951.460060-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180228231951.460060-1-arnd@arndb.de> Organisation: Horms Solutions BV User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 01, 2018 at 12:19:37AM +0100, Arnd Bergmann wrote: > The PM runtime operations are unused when CONFIG_PM is disabled, > leading to a harmless warning: > > drivers/media/platform/renesas-ceu.c:1003:12: error: 'ceu_runtime_suspend' defined but not used [-Werror=unused-function] > static int ceu_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~ > drivers/media/platform/renesas-ceu.c:987:12: error: 'ceu_runtime_resume' defined but not used [-Werror=unused-function] > static int ceu_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~ > > This adds a __maybe_unused annotation to shut up the warning. > > Fixes: 32e5a70dc8f4 ("media: platform: Add Renesas CEU driver") > Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman