From: Mark Rutland <mark.rutland@arm.com>
To: Benjamin Gaignard <benjamin.gaignard@linaro.org>
Cc: robh+dt@kernel.org, mcoquelin.stm32@gmail.com,
alexandre.torgue@st.com, robin.murphy@arm.com, arnd@arndb.de,
loic.pallardy@st.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH v2 0/2] STM32 Extended TrustZone Protection driver
Date: Thu, 1 Mar 2018 14:02:43 +0000 [thread overview]
Message-ID: <20180301140243.3uamdvdcvmsxv6im@lakrids.cambridge.arm.com> (raw)
In-Reply-To: <20180301135806.19982-1-benjamin.gaignard@st.com>
On Thu, Mar 01, 2018 at 02:58:04PM +0100, Benjamin Gaignard wrote:
> On early boot stages STM32MP1 platform is able to dedicate some hardware blocks
> to a secure OS running in TrustZone.
> We need to avoid using those hardware blocks on non-secure context (i.e. kernel)
> because read/write accesses could generate illegale access exceptions.
>
> Extended TrustZone Protection driver make sure that device is disabled if
> non-secure world can't acces to it.
>
> version 2:
> - do not use notifier anymore
> - change status property value in device-tree if needed
> - use a list of phandle instead of hard coded array
As mentioned on v1, I don't think this should be done in Linux at all.
If you wish to handle this dynamically, please fixup the DT *before*
entering Linux.
If you want a sane default in the dts file, put status = "disabled" on
all nodes which the secure world might take ownership of.
Thanks,
Mark.
> NOTE: Those patches should be applied only on
> git://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
> until this patch: https://lkml.org/lkml/2018/2/26/386
> find it way to mainline because KBuild will complain about them.
>
> Benjamin Gaignard (2):
> dt-bindings: stm32: Add bindings for Extended TrustZone Protection
> ARM: mach-stm32: Add Extended TrustZone Protection driver
>
> .../bindings/arm/stm32/st,stm32mp1-etzpc.txt | 25 +++++
> arch/arm/mach-stm32/Kconfig | 7 ++
> arch/arm/mach-stm32/Makefile | 1 +
> arch/arm/mach-stm32/stm32-etzpc.c | 116 +++++++++++++++++++++
> 4 files changed, 149 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/stm32/st,stm32mp1-etzpc.txt
> create mode 100644 arch/arm/mach-stm32/stm32-etzpc.c
>
> --
> 2.15.0
>
next prev parent reply other threads:[~2018-03-01 14:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 13:58 Benjamin Gaignard
2018-03-01 13:58 ` [PATCH v2 1/2] dt-bindings: stm32: Add bindings for Extended TrustZone Protection Benjamin Gaignard
2018-03-01 14:03 ` Mark Rutland
2018-03-01 14:09 ` Benjamin Gaignard
2018-03-01 13:58 ` [PATCH v2 2/2] ARM: mach-stm32: Add Extended TrustZone Protection driver Benjamin Gaignard
2018-03-01 14:02 ` Mark Rutland [this message]
2018-03-01 14:15 ` [PATCH v2 0/2] STM32 " Benjamin Gaignard
2018-03-01 14:19 ` Robin Murphy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301140243.3uamdvdcvmsxv6im@lakrids.cambridge.arm.com \
--to=mark.rutland@arm.com \
--cc=alexandre.torgue@st.com \
--cc=arnd@arndb.de \
--cc=benjamin.gaignard@linaro.org \
--cc=benjamin.gaignard@st.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loic.pallardy@st.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®