From: Joey Pabalinas <joeypabalinas@gmail.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
ALSA Development Mailing List <alsa-devel@alsa-project.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Joey Pabalinas <joeypabalinas@gmail.com>
Subject: Re: [PATCH] sound/pci/ice1712: replace strcpy() with scnprintf()
Date: Thu, 1 Mar 2018 04:10:23 -1000 [thread overview]
Message-ID: <20180301141023.kc2cb7xrjx2csgvr@gmail.com> (raw)
In-Reply-To: <CAHp75Vf6kfPE_sRPj_mLMvLQfn9Fe9B_MeXqnGAHGAdzR7HX+Q@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 256 bytes --]
On Thu, Mar 01, 2018 at 03:55:09PM +0200, Andy Shevchenko wrote:
> So, why not just use strlcpy()?
> scnprintf() here adds an overhead for no benefit.
That's a good point, actually. Revising it now; patch
will follow shortly.
--
Joey Pabalinas
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-03-01 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 11:45 Joey Pabalinas
2018-03-01 13:55 ` Andy Shevchenko
2018-03-01 14:10 ` Joey Pabalinas [this message]
2018-03-01 14:17 ` [PATCH v2] sound/pci/ice1712: replace strcpy() with strlcpy() Joey Pabalinas
2018-03-01 14:21 ` Andy Shevchenko
2018-03-01 15:13 ` Takashi Iwai
2018-03-01 15:22 ` Joey Pabalinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180301141023.kc2cb7xrjx2csgvr@gmail.com \
--to=joeypabalinas@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome