From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031592AbeCAOu0 (ORCPT ); Thu, 1 Mar 2018 09:50:26 -0500 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39632 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031346AbeCAOuZ (ORCPT ); Thu, 1 Mar 2018 09:50:25 -0500 Date: Thu, 1 Mar 2018 14:50:18 +0000 From: Lorenzo Pieralisi To: Ryder Lee Cc: Bjorn Helgaas , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] dt-bindings: PCI: MediaTek: fix dtc warnings Message-ID: <20180301145018.GA2516@e107981-ln.cambridge.arm.com> References: <9940757fe2889f46d0de214c5f277bf3c2074205.1518577579.git.ryder.lee@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <9940757fe2889f46d0de214c5f277bf3c2074205.1518577579.git.ryder.lee@mediatek.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 14, 2018 at 11:27:58AM +0800, Ryder Lee wrote: > dtc recently added PCI bus checks. Fix these warnings: > > Warning (pci_bridge): Node /pcie@1a140000/pcie@0,0 missing bus-range for PCI bridge > Warning (pci_bridge): Node /pcie@1a140000/pcie@1,0 missing bus-range for PCI bridge > Warning (pci_bridge): Node /pcie@1a140000/pcie@2,0 missing bus-range for PCI bridge > Warning (unit_address_format): Failed prerequisite 'pci_bridge' > Warning (pci_device_reg): Failed prerequisite 'pci_bridge' > Warning (pci_device_bus_num): Failed prerequisite 'pci_bridge' > > Signed-off-by: Ryder Lee > --- > Documentation/devicetree/bindings/pci/mediatek-pcie.txt | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) Given that changes to these bindings always went through the PCI tree, I've applied this patch to pci/mediatek for v4.17, thanks. Lorenzo > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > index 3a6ce55..20227a8 100644 > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie.txt > @@ -78,7 +78,7 @@ Examples for MT7623: > #reset-cells = <1>; > }; > > - pcie: pcie-controller@1a140000 { > + pcie: pcie@1a140000 { > compatible = "mediatek,mt7623-pcie"; > device_type = "pci"; > reg = <0 0x1a140000 0 0x1000>, /* PCIe shared registers */ > @@ -111,7 +111,6 @@ Examples for MT7623: > 0x83000000 0 0x60000000 0 0x60000000 0 0x10000000>; /* memory space */ > > pcie@0,0 { > - device_type = "pci"; > reg = <0x0000 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > @@ -123,7 +122,6 @@ Examples for MT7623: > }; > > pcie@1,0 { > - device_type = "pci"; > reg = <0x0800 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > @@ -135,7 +133,6 @@ Examples for MT7623: > }; > > pcie@2,0 { > - device_type = "pci"; > reg = <0x1000 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > @@ -148,6 +145,7 @@ Examples for MT7623: > }; > > Examples for MT2712: > + > pcie: pcie@11700000 { > compatible = "mediatek,mt2712-pcie"; > device_type = "pci"; > @@ -169,7 +167,6 @@ Examples for MT2712: > ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > pcie0: pcie@0,0 { > - device_type = "pci"; > reg = <0x0000 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > @@ -189,7 +186,6 @@ Examples for MT2712: > }; > > pcie1: pcie@1,0 { > - device_type = "pci"; > reg = <0x0800 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > @@ -210,6 +206,7 @@ Examples for MT2712: > }; > > Examples for MT7622: > + > pcie: pcie@1a140000 { > compatible = "mediatek,mt7622-pcie"; > device_type = "pci"; > @@ -243,7 +240,6 @@ Examples for MT7622: > ranges = <0x82000000 0 0x20000000 0x0 0x20000000 0 0x10000000>; > > pcie0: pcie@0,0 { > - device_type = "pci"; > reg = <0x0000 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > @@ -263,7 +259,6 @@ Examples for MT7622: > }; > > pcie1: pcie@1,0 { > - device_type = "pci"; > reg = <0x0800 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > -- > 1.9.1 >