From: Dave Young <dyoung@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@redhat.com>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, bhe@redhat.com,
slp@redhat.com, mst@redhat.com, somlo@cmu.edu,
xiaolong.ye@intel.com, Andrew Morton <akpm@linux-foundation.org>,
Hari Bathini <hbathini@linux.vnet.ibm.com>,
Tony Luck <tony.luck@intel.com>, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note()
Date: Fri, 2 Mar 2018 10:32:04 +0800 [thread overview]
Message-ID: <20180302023204.GA2818@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20180228150615.17317-10-marcandre.lureau@redhat.com>
Hi
On 02/28/18 at 04:06pm, Marc-André Lureau wrote:
> The following patch is going to use the symbol from the fw_cfg module,
> to call the function and write the note location details in the
> vmcoreinfo entry, so qemu can produce dumps with the vmcoreinfo note.
>
> CC: Andrew Morton <akpm@linux-foundation.org>
> CC: Baoquan He <bhe@redhat.com>
> CC: Dave Young <dyoung@redhat.com>
> CC: Dave Young <dyoung@redhat.com>
Above duplicated a CC, btw, I remember both Baoquan and me acked it
before, you can find the old email and carry the acked-by.
> CC: Hari Bathini <hbathini@linux.vnet.ibm.com>
> CC: Tony Luck <tony.luck@intel.com>
> CC: Vivek Goyal <vgoyal@redhat.com>
> Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> Acked-by: Gabriel Somlo <somlo@cmu.edu>
> ---
> kernel/crash_core.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> index 4f63597c824d..a93590cdd9e1 100644
> --- a/kernel/crash_core.c
> +++ b/kernel/crash_core.c
> @@ -376,6 +376,7 @@ phys_addr_t __weak paddr_vmcoreinfo_note(void)
> {
> return __pa(vmcoreinfo_note);
> }
> +EXPORT_SYMBOL(paddr_vmcoreinfo_note);
>
> static int __init crash_save_vmcoreinfo_init(void)
> {
> --
> 2.16.1.73.g5832b7e9f2
>
Thanks
Dave
next prev parent reply other threads:[~2018-03-02 2:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 15:06 [PATCH v16 00/11] fw_cfg: add DMA operations & etc/vmcoreinfo support Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 01/11] fw_cfg: fix sparse warnings in fw_cfg_sel_endianness() Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 02/11] fw_cfg: fix sparse warnings with fw_cfg_file Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 03/11] fw_cfg: fix sparse warning reading FW_CFG_ID Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 04/11] fw_cfg: fix sparse warnings around FW_CFG_FILE_DIR read Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 05/11] fw_cfg: remove inline from fw_cfg_read_blob() Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 06/11] fw_cfg: handle fw_cfg_read_blob() error Marc-André Lureau
2018-02-28 17:32 ` Michael S. Tsirkin
2018-03-01 11:36 ` Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 07/11] fw_cfg: add a public uapi header Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 08/11] fw_cfg: add DMA register Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 09/11] crash: export paddr_vmcoreinfo_note() Marc-André Lureau
2018-03-02 2:32 ` Dave Young [this message]
2018-03-02 18:03 ` Michael S. Tsirkin
2018-03-02 18:09 ` Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 10/11] fw_cfg: write vmcoreinfo details Marc-André Lureau
2018-02-28 15:06 ` [PATCH v16 11/11] RFC: fw_cfg: do DMA read operation Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302023204.GA2818@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=bhe@redhat.com \
--cc=hbathini@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcandre.lureau@redhat.com \
--cc=mst@redhat.com \
--cc=slp@redhat.com \
--cc=somlo@cmu.edu \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®