From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1330670-1519988601-2-9100884379744126992 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.249, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, UNPARSEABLE_RELAY 0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1519988600; b=dqUAAfKhfyhNTP3Mpm6IB0xRtb1YQuAzYHHICMvGo9wntux 2Wtjse0DObxnF65iKcUJoFtZ2i0875gTzk1D2LiDxRZ/B5CApUAIp2eUfNb6uXSU VtbqbLIWCtgpwP/pZ0CA+K+TtpHd7F0DUSSG42S/T8SFDYtEk+ygUwpUxfAHaEK8 axqLT+jIqTQjIbT88E9MYIWUvqTE0wBzL3eop6qnPrluBeX+JCDyd3NKYud4DYaZ JKFz37xcaEwI857t+e4W9eDVAzYlTeHhfontUCaopjunF00uIF9CYiPEVrKnsBNW smpR97U5RJdyLYHkvm5PxxVosCq78zV9zu5Sk8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to:sender :list-id; s=arctest; t=1519988600; bh=AdrNPALNIXN8qakYmv4wms/o71 wS3DdZPMkCVvy0SH0=; b=k3e9GkXhxMP6u1La6NbsgV3/MCt2c5JsMS15gvJXm4 xQ7DtcnVS5ISTjdG/IuP2NOtGXKZ8KaWuvkLyLitMRr+LErCyONw2U28jZtobcFn mZpl7iohTE7rpV6jk0SpLE5gjYpk5SVsbMdPI/Wqt3fkuyil0o6ttnNp56n48/BP npOM2hgwEO7jSo5H04Vszz+dlZQNIpRTXcaaeL2h0RgJn5NJkDYRFQoW9hquLeP+ YIQJBA6afjT8e2EMSQpK02laDjDiwS0OuuvOvpRCFGkPOkRD30ed8FsVIKlHmlz3 bhRY6NQbf0fbzwjL28JJC9KnKdGngqs9Ec8YmGm7LACQ== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=VWk7n9Py x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=oracle.com header.result=pass header_is_org_domain=yes Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=pass (2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=VWk7n9Py x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=pass (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=oracle.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426826AbeCBLCy (ORCPT ); Fri, 2 Mar 2018 06:02:54 -0500 Received: from userp2120.oracle.com ([156.151.31.85]:46138 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423716AbeCBLCs (ORCPT ); Fri, 2 Mar 2018 06:02:48 -0500 Date: Fri, 2 Mar 2018 14:02:12 +0300 From: Dan Carpenter To: Wolfram Sang Cc: Krzysztof Kozlowski , Kukjin Kim , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Ben Dooks , stable@vger.kernel.org Subject: Re: [PATCH] i2c: s3c2410: Properly handle interrupts of number 0 Message-ID: <20180302110212.7wfk6hn4tf5l7ax4@mwanda> References: <1519936484-23132-1-git-send-email-krzk@kernel.org> <20180302102926.fuqmfyaxiujjwill@ninjato> <20180302110002.wmkvktobi7ssmin5@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180302110002.wmkvktobi7ssmin5@mwanda> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8819 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=840 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803020129 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Fri, Mar 02, 2018 at 02:00:03PM +0300, Dan Carpenter wrote: > On Fri, Mar 02, 2018 at 11:29:26AM +0100, Wolfram Sang wrote: > > On Thu, Mar 01, 2018 at 09:34:44PM +0100, Krzysztof Kozlowski wrote: > > > Interrupt number 0 (returned by platform_get_irq()) might be a valid IRQ > > > so do not treat it as an error. If interrupt 0 was configured, the driver > > > would exit the probe early, before finishing initialization, but with > > > 0-exit status. > > > > > > Reported-by: Dan Carpenter > > > Cc: stable@vger.kernel.org > > > Fixes: e0d1ec97853f ("i2c-s3c2410: Change IRQ to be plain integer.") > > > > Please configure git to use 14 digits here. > > Wait, when did we decide that 12 wasn't enough? > > I just did a `git log | grep Fixes | tee baz | head -n 200` and only on > my git tree tehre were only 2 which used exactly 14 digits. The > standard is 12. Wow... I clearly did not read that email before sending it... :( regards, dan carpenter