From: Enric Balletbo i Serra <enric.balletbo@collabora.com>
To: "Sandy Huang" <hjc@rock-chips.com>, "Heiko Stübner" <heiko@sntech.de>
Cc: Andrzej Hajda <a.hajda@samsung.com>,
linux-rockchip@lists.infradead.org,
Archit Taneja <architt@codeaurora.org>,
linux-kernel@vger.kernel.org,
Russell King <rmk+kernel@armlinux.org.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
dri-devel@lists.freedesktop.org,
Jose Abreu <Jose.Abreu@synopsys.com>,
Hans Verkuil <hverkuil@xs4all.nl>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
linux-arm-kernel@lists.infradead.org,
David Airlie <airlied@linux.ie>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
kernel@collabora.com,
Enric Balletbo i Serra <enric.balletbo@collabora.com>
Subject: [PATCH v9 1/5] drm/rockchip: dw-mipi-dsi: Fix connector and encoder cleanup.
Date: Fri, 2 Mar 2018 18:57:53 +0100 [thread overview]
Message-ID: <20180302175757.28192-2-enric.balletbo@collabora.com> (raw)
In-Reply-To: <20180302175757.28192-1-enric.balletbo@collabora.com>
From: Jeffy Chen <jeffy.chen@rock-chips.com>
In bind()'s error handling path call destroy functions instead of
cleanup functions for encoder and connector and reorder to match how is
called in bind().
In unbind() call the connector and encoder destroy functions.
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
Signed-off-by: Thierry Escande <thierry.escande@collabora.com>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
---
Changes in v9:
- Removed the pm_runtime_disable call as is not really needed.
drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
index 591953cbdd18..d53d5a09547f 100644
--- a/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
+++ b/drivers/gpu/drm/rockchip/dw-mipi-dsi.c
@@ -1302,8 +1302,8 @@ static int dw_mipi_dsi_bind(struct device *dev, struct device *master,
err_mipi_dsi_host:
mipi_dsi_host_unregister(&dsi->dsi_host);
err_cleanup:
- drm_encoder_cleanup(&dsi->encoder);
- drm_connector_cleanup(&dsi->connector);
+ dsi->connector.funcs->destroy(&dsi->connector);
+ dsi->encoder.funcs->destroy(&dsi->encoder);
err_pllref:
clk_disable_unprepare(dsi->pllref_clk);
return ret;
@@ -1316,6 +1316,10 @@ static void dw_mipi_dsi_unbind(struct device *dev, struct device *master,
mipi_dsi_host_unregister(&dsi->dsi_host);
pm_runtime_disable(dev);
+
+ dsi->connector.funcs->destroy(&dsi->connector);
+ dsi->encoder.funcs->destroy(&dsi->encoder);
+
clk_disable_unprepare(dsi->pllref_clk);
}
--
2.16.1
next prev parent reply other threads:[~2018-03-02 17:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 17:57 [PATCH v9 0/5] rockchip: kevin: Enable edp display Enric Balletbo i Serra
2018-03-02 17:57 ` Enric Balletbo i Serra [this message]
2018-03-08 16:38 ` [PATCH v9 1/5] drm/rockchip: dw-mipi-dsi: Fix connector and encoder cleanup Heiko Stübner
2018-03-02 17:57 ` [PATCH v9 2/5] drm/rockchip: inno_hdmi: Fix error handling path Enric Balletbo i Serra
2018-03-08 16:38 ` Heiko Stübner
2018-03-02 17:57 ` [PATCH v9 3/5] drm/rockchip: inno_hdmi: reorder clk_disable_unprepare call in unbind Enric Balletbo i Serra
2018-03-08 16:38 ` Heiko Stübner
2018-03-02 17:57 ` [PATCH v9 4/5] drm/rockchip: dw_hdmi: Move HDMI vpll clock enable to bind() Enric Balletbo i Serra
2018-03-08 16:38 ` Heiko Stübner
2018-03-02 17:57 ` [PATCH v9 5/5] drm/bridge/synopsys: dw-hdmi: Add missing bridge detach Enric Balletbo i Serra
2018-03-02 21:49 ` Laurent Pinchart
2018-03-03 0:20 ` JeffyChen
2018-03-05 7:01 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180302175757.28192-2-enric.balletbo@collabora.com \
--to=enric.balletbo@collabora.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=heiko@sntech.de \
--cc=hjc@rock-chips.com \
--cc=hverkuil@xs4all.nl \
--cc=jeffy.chen@rock-chips.com \
--cc=jernej.skrabec@siol.net \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=rmk+kernel@armlinux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®