From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1312649-1520122960-2-13999040760289250423 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.249, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520122960; b=NLY5+0zIgb54lcOw1o8nEkq49k7TxolorXwaeqjQIIGXSzf mHrwS1Wc0bV5Emkz9PZ/VTnGfps8OSw3SbmbRAMCeOEhD8ihBCfKZvprKMfiTNOc HBNcciR+qwnEzqHcR9QpE4VPcjwupBN0A/LbVlMY9ZLGXm6BY/vlbWvFIL5FE8As 9u7+8MNZtXERXHE0gdXvvErp8fOGe16jIGSnDr9/nWsaNbbcIeqmWnQCqvUNiILz k3D+g0uToB0sac9ZcFDnlnK8DjfrnrPnBwpHdvvoZDH2bztFJ/uxanEomXHfmTXr AF28ZiBB0PHoWlHptwg1taSmlLMcivvfUig+Yag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1520122960; bh=oTJI9A OfopbY9mapVPd0FghdrjUGDqHg0MrY6VuTKLY=; b=qHIiDOHE/uBO/anTLbHzRE c5rKn//0bzstKYAwH+zSxcr+/sNSs6on94UHG+FWbqUxlkX069t864Ii+IUqpxye OCor3l+g0dTq4zc7haywDauExi/WYl9jZ62oBElpCjvCGUkv3q9y/sIoABNX14uc 3xq+mP3eAdJBroRkHdjDfVWU9RZ5MlmO0iNhw3ZmoNXvahPryW2KUlpGBM60S+iq fiNzfC9sqRP0+jM7Fe4cpK1kaxNF3MZofY9eihgyd7AtCr9vALLRFq+xhQ2GhjUL OCN3hFwdGkuXYIRUoZhtR1HHZ6lvjO2rFqAdxFqsBOjjebFRj1VUCnGdophSLOvw == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Ry0Z1gBL x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=Ry0Z1gBL x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933047AbeCDAVx (ORCPT ); Sat, 3 Mar 2018 19:21:53 -0500 Received: from mail-by2nam01on0114.outbound.protection.outlook.com ([104.47.34.114]:45301 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932741AbeCCW24 (ORCPT ); Sat, 3 Mar 2018 17:28:56 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Christophe JAILLET , Sebastian Reichel , Sasha Levin Subject: [PATCH AUTOSEL for 4.14 34/84] power: supply: ab8500_charger: Bail out in case of error in 'ab8500_charger_init_hw_registers()' Thread-Topic: [PATCH AUTOSEL for 4.14 34/84] power: supply: ab8500_charger: Bail out in case of error in 'ab8500_charger_init_hw_registers()' Thread-Index: AQHTsz6nnFoYTtwUKkyCZFZHgy73mg== Date: Sat, 3 Mar 2018 22:26:19 +0000 Message-ID: <20180303222518.26271-34-alexander.levin@microsoft.com> References: <20180303222518.26271-1-alexander.levin@microsoft.com> In-Reply-To: <20180303222518.26271-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1115;7:iehVKKjEa1pJkCIw9X+Z0F1hGB50sxEvIdZuP29yq4HUdjUaWQO716EB6OsZ+jPnHM9fcm4Yf6H/XActiFIDpaq62BPI+PQ1YPssvI2+dOLtwB2rLja1GkpFjRP5MaYk9YdMPHUcDIGWlbHCOB8XtTJ87KrRGzQBkMCp/rHkmxN1L11+u+hhKTBqC23V1By3x8xh+wYyj+Qp6Ko/i4JgLtvgcnivGwSBRmGcuSOSeqKs6lx0Pw7VdHfwPEK3TzU0 x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 03e2f6e0-5df9-42f5-1b67-08d58156260b x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603307)(7193020);SRVR:MW2PR2101MB1115; x-ms-traffictypediagnostic: MW2PR2101MB1115: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(155761271638844); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(3002001)(3231220)(944501244)(52105095)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123558120)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1115;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1115; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(39860400002)(346002)(366004)(39380400002)(189003)(199004)(26005)(97736004)(186003)(2900100001)(316002)(59450400001)(6506007)(102836004)(36756003)(110136005)(106356001)(54906003)(72206003)(4326008)(8676002)(81156014)(25786009)(2950100002)(6666003)(305945005)(10290500003)(5660300001)(107886003)(14454004)(8936002)(3660700001)(3280700002)(105586002)(81166006)(478600001)(2906002)(6116002)(3846002)(1076002)(2501003)(6436002)(5250100002)(6486002)(68736007)(7736002)(10090500001)(6512007)(66066001)(53936002)(15760500003)(99286004)(86612001)(76176011)(22452003)(86362001)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1115;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: wKWlkb+IpDDmqBV2cWS1APMRpwbPW3WJhcd1u276N5EPTtDpJRHjfrqL7DL3GvnAS+qVGrsAvFrwOYxM5FNdBNBVcnW30VsQHyhIVEZqameX6kyCqz1j3VOZpVuA2IHa3oxB1+4+GG+ai0j/EvrKgw0PTr1rLFeHZSwlpIKePP8= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 03e2f6e0-5df9-42f5-1b67-08d58156260b X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:26:19.5879 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1115 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Christophe JAILLET [ Upstream commit 09edcb647542487864e23aa8d2ef26be3e08978a ] If an error occurs when we enable the backup battery charging, we should go through the error handling path directly. Before commit db43e6c473b5 ("ab8500-bm: Add usb power path support") this was the case, but this commit has added some code between the last test and the 'out' label. So, in case of error, this added code is executed and the error may be silently ignored. Fix it by adding the missing 'goto out', as done in all other error handling paths. Fixes: db43e6c473b5 ("ab8500-bm: Add usb power path support") Signed-off-by: Christophe JAILLET Signed-off-by: Sebastian Reichel Signed-off-by: Sasha Levin --- drivers/power/supply/ab8500_charger.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/a= b8500_charger.c index 1cdbe7a0738d..5a76c6d343de 100644 --- a/drivers/power/supply/ab8500_charger.c +++ b/drivers/power/supply/ab8500_charger.c @@ -3221,8 +3221,10 @@ static int ab8500_charger_init_hw_registers(struct a= b8500_charger *di) ret =3D abx500_mask_and_set_register_interruptible(di->dev, AB8500_RTC, AB8500_RTC_CTRL_REG, RTC_BUP_CH_ENA, RTC_BUP_CH_ENA); - if (ret < 0) + if (ret < 0) { dev_err(di->dev, "%s mask and set failed\n", __func__); + goto out; + } =20 if (is_ab8540(di->parent)) { ret =3D abx500_mask_and_set_register_interruptible(di->dev, --=20 2.14.1