From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1211789-1520118938-2-4034509581249981343 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.249, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520118938; b=pXJn3hi0pg+wTLKyt6UMP3mfa9h8rUC8UUSL2eEeqLt3cV6 Ulh4IixCISZ/UtiSMPf2jN0DAgTEv04Ru7kI2i/yal0hqiEKaiXwutMEbQXNcTwu KiWvrFGOCKZQvevgSoZTFix0ONmgicDUqIPZhD4nZEyCE/VGUcJ9m0dnLcgk+LM+ ijvb//+aEnPlzWkgg6gi8jdzNnGpS08Kd3zX7ONS1ceqsnC4bALNMKyqskJTgK/f nZArXyQoj5d3RGBVqz17KC6+UFxSEjBBU+u0dj4I4H7rtwZFsX1JWnPtwkX5SyFU N2iE/N3RyLaqgFBSvc/iT13m2Px8cZLlEpkb+bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1520118938; bh=wzHzvZ H9sN1p39Jn+iVdyRj9LlwMiavWllhUjziLXjk=; b=AUgi9zJdq2XDiNLY+oROis tAYhxetupos/93SlHRKlO5sNCTgHj08UXGs8wcXdQd+duqyg7G+FLmFhr6UhXbXU srBRldo57Y8fHXWV0mExqGSCuq5Lefpm28vkgyK3aIS+HTxJgv/TTcCYRiOeGZqz dSAQbZI5QLkEXfn8SQzmn+S1J7PTKNVNpXvdqeGSoYcMrF5yYGUVLEKbh86HZV2f yeydObr4b5akb5brnGKNXTXwkghKdIpozXMzBmCqv1twdfaFGbJJ/NuAGmFNFLvS L+3EYOqQUOU2QsYmbwA4T4oQn8gC2UWyLohPmtkAgTgZ+UtV8lNRHyPLYrEX7dcQ == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=P8ywlOT+ x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=P8ywlOT+ x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934939AbeCCWiT (ORCPT ); Sat, 3 Mar 2018 17:38:19 -0500 Received: from mail-cys01nam02on0126.outbound.protection.outlook.com ([104.47.37.126]:19904 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S934892AbeCCWiP (ORCPT ); Sat, 3 Mar 2018 17:38:15 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Tom Hromatka , John Stultz , Sasha Levin Subject: [PATCH AUTOSEL for 4.4 028/115] sysrq: Reset the watchdog timers while displaying high-resolution timers Thread-Topic: [PATCH AUTOSEL for 4.4 028/115] sysrq: Reset the watchdog timers while displaying high-resolution timers Thread-Index: AQHTsz9RcR/xsnyaVk2rtxGZDjECDQ== Date: Sat, 3 Mar 2018 22:31:04 +0000 Message-ID: <20180303223010.27106-28-alexander.levin@microsoft.com> References: <20180303223010.27106-1-alexander.levin@microsoft.com> In-Reply-To: <20180303223010.27106-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;MW2PR2101MB1067;7:gczo8N2wMvVvIGVAPgc+A6xm19oJJHggbkM/oGwAMBj2/zfJM4AhWzG9k5WpRafZP9wbkJXJg1zmkg1ptDBIjPgd+ZyQ1Qk5DyF5VivLaBWujPwWyApE2K5AIfMMSi8HFc0lERs0xGDF8umakazbiH+/gwWpvmr1HH/NinBGgGNH0obctkVWuovHN2bQXH5sRypt264uVjJh/mA/5qo4ERdNUmi9TLv+U57wxbKoz8x6FD+NN8GXcpHTKpHr8WmU x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: a767c910-cf04-4db3-59b2-08d581577122 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(48565401081)(5600026)(4604075)(3008032)(2017052603307)(7193020);SRVR:MW2PR2101MB1067; x-ms-traffictypediagnostic: MW2PR2101MB1067: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(89211679590171)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(5005006)(8121501046)(3231220)(944501244)(52105095)(3002001)(10201501046)(93006095)(93001095)(6055026)(61426038)(61427038)(6041288)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(20161123564045)(20161123560045)(20161123562045)(6072148)(201708071742011);SRVR:MW2PR2101MB1067;BCL:0;PCL:0;RULEID:;SRVR:MW2PR2101MB1067; x-forefront-prvs: 0600F93FE1 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(366004)(376002)(39860400002)(39380400002)(346002)(199004)(189003)(4326008)(5250100002)(86362001)(1076002)(2501003)(110136005)(6666003)(81156014)(2906002)(8936002)(305945005)(81166006)(2950100002)(7736002)(10290500003)(26005)(186003)(3660700001)(478600001)(72206003)(107886003)(8676002)(3280700002)(59450400001)(2900100001)(76176011)(6116002)(25786009)(3846002)(102836004)(6506007)(5660300001)(97736004)(10090500001)(86612001)(106356001)(99286004)(6512007)(66066001)(316002)(53936002)(14454004)(105586002)(36756003)(6486002)(54906003)(6436002)(68736007)(22452003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:MW2PR2101MB1067;H:MW2PR2101MB1034.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-microsoft-antispam-message-info: KbKU0cUQ9RhrtzBFJw3BuDDvrgJpxXPXFFPu7TIVAkmpZ0NF3R0pK3Ij+KAh/rZbeNz7RaGRx2/YHIpqCvk1u6hdYnh8XJowLryGrlL7aU5GBPlRWv/i2eGs5RxClDZj2cxCoFAhF0L03D7Os4F6z8shgScPdywiVtMyMu4YP1g= spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: a767c910-cf04-4db3-59b2-08d581577122 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Mar 2018 22:31:04.9946 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2PR2101MB1067 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Tom Hromatka [ Upstream commit 0107042768658fea9f5f5a9c00b1c90f5dab6a06 ] On systems with a large number of CPUs, running sysrq- can cause watchdog timeouts. There are two slow sections of code in the sysrq- path in timer_list.c. 1. print_active_timers() - This function is called by print_cpu() and contains a slow goto loop. On a machine with hundreds of CPUs, this loop took approximately 100ms for the first CPU in a NUMA node. (Subsequent CPUs in the same node ran much quicker.) The total time to print all of the CPUs is ultimately long enough to trigger the soft lockup watchdog. 2. print_tickdevice() - This function outputs a large amount of textual information. This function also took approximately 100ms per CPU. Since sysrq- is not a performance critical path, there should be no harm in touching the nmi watchdog in both slow sections above. Touching it in just one location was insufficient on systems with hundreds of CPUs as occasional timeouts were still observed during testing. This issue was observed on an Oracle T7 machine with 128 CPUs, but I anticipate it may affect other systems with similarly large numbers of CPUs. Signed-off-by: Tom Hromatka Reviewed-by: Rob Gardner Signed-off-by: John Stultz Signed-off-by: Sasha Levin --- kernel/time/timer_list.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/kernel/time/timer_list.c b/kernel/time/timer_list.c index ba7d8b288bb3..ef4f16e81283 100644 --- a/kernel/time/timer_list.c +++ b/kernel/time/timer_list.c @@ -16,6 +16,7 @@ #include #include #include +#include =20 #include =20 @@ -96,6 +97,9 @@ print_active_timers(struct seq_file *m, struct hrtimer_cl= ock_base *base, =20 next_one: i =3D 0; + + touch_nmi_watchdog(); + raw_spin_lock_irqsave(&base->cpu_base->lock, flags); =20 curr =3D timerqueue_getnext(&base->active); @@ -207,6 +211,8 @@ print_tickdevice(struct seq_file *m, struct tick_device= *td, int cpu) { struct clock_event_device *dev =3D td->evtdev; =20 + touch_nmi_watchdog(); + SEQ_printf(m, "Tick Device: mode: %d\n", td->mode); if (cpu < 0) SEQ_printf(m, "Broadcast device\n"); --=20 2.14.1