From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752352AbeCEDQ5 (ORCPT ); Sun, 4 Mar 2018 22:16:57 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:46940 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751989AbeCEDQz (ORCPT ); Sun, 4 Mar 2018 22:16:55 -0500 Date: Sun, 04 Mar 2018 22:16:51 -0500 (EST) Message-Id: <20180304.221651.1758033941719841960.davem@davemloft.net> To: jasowang@redhat.com Cc: mst@redhat.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, brouer@redhat.com, john.fastabend@gmail.com Subject: Re: [PATCH net V2] virtio-net: re enable XDP_REDIRECT for mergeable buffer From: David Miller In-Reply-To: <986bd816-2452-9eca-ec8a-ce267ef49a2d@redhat.com> References: <1519982954-14360-1-git-send-email-jasowang@redhat.com> <20180304.183811.344767417258525977.davem@davemloft.net> <986bd816-2452-9eca-ec8a-ce267ef49a2d@redhat.com> X-Mailer: Mew version 6.7 on Emacs 25.3 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jason Wang Date: Mon, 5 Mar 2018 10:43:41 +0800 > > > On 2018年03月05日 07:38, David Miller wrote: >> From: Jason Wang >> Date: Fri, 2 Mar 2018 17:29:14 +0800 >> >>> XDP_REDIRECT support for mergeable buffer was removed since commit >>> 7324f5399b06 ("virtio_net: disable XDP_REDIRECT in receive_mergeable() >>> case"). This is because we don't reserve enough tailroom for struct >>> skb_shared_info which breaks XDP assumption. So this patch fixes this >>> by reserving enough tailroom and using fixed size of rx buffer. >>> >>> Signed-off-by: Jason Wang >>> --- >>> Changes from V1: >>> - do not add duplicated tracepoint when redirection fails >> Applied to net-next, thanks Jason. > > Hi David, > > Consider the change is not large, any chance to make it for -net to > keep XDP redirection work? Ok, I'll apply this to 'net' too.