From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752691AbeCDLOf (ORCPT ); Sun, 4 Mar 2018 06:14:35 -0500 Received: from mga11.intel.com ([192.55.52.93]:20789 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751844AbeCDLOd (ORCPT ); Sun, 4 Mar 2018 06:14:33 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,422,1515484800"; d="scan'208";a="22413971" Date: Sun, 4 Mar 2018 19:13:33 +0800 From: kbuild test robot To: Andrey Smirnov Cc: kbuild-all@01.org, Srinivas Kandagatla , Andrey Smirnov , Heiko Stuebner , Masahiro Yamada , Carlo Caione , Kevin Hilman , Matthias Brugger , cphealy@gmail.com, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH] nvmem: meson-mx-efuse: fix ptr_ret.cocci warnings Message-ID: <20180304111333.GA24937@lkp-hsx02> References: <20180228144106.16363-12-andrew.smirnov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180228144106.16363-12-andrew.smirnov@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: fengguang.wu@intel.com X-SA-Exim-Scanned: No (on bee); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Fengguang Wu drivers/nvmem/meson-mx-efuse.c:237:1-3: WARNING: PTR_ERR_OR_ZERO can be used Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR Generated by: scripts/coccinelle/api/ptr_ret.cocci Fixes: 37ef5352c0f7 ("nvmem: meson-mx-efuse: Convert to use devm_nvmem_register()") CC: Andrey Smirnov Signed-off-by: Fengguang Wu --- meson-mx-efuse.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) --- a/drivers/nvmem/meson-mx-efuse.c +++ b/drivers/nvmem/meson-mx-efuse.c @@ -234,10 +234,7 @@ static int meson_mx_efuse_probe(struct p } efuse->nvmem = devm_nvmem_register(&pdev->dev, &efuse->config); - if (IS_ERR(efuse->nvmem)) - return PTR_ERR(efuse->nvmem); - - return 0; + return PTR_ERR_OR_ZERO(efuse->nvmem); } static struct platform_driver meson_mx_efuse_driver = {