From: Tomas Winkler <tomas.winkler@intel.com>
To: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
Jason Gunthorpe <jgg@ziepe.ca>
Cc: Alexander Usyskin <alexander.usyskin@intel.com>,
linux-integrity@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Tomas Winkler <tomas.winkler@intel.com>
Subject: [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address
Date: Sun, 4 Mar 2018 14:12:05 +0200 [thread overview]
Message-ID: <20180304121205.16934-3-tomas.winkler@intel.com> (raw)
In-Reply-To: <20180304121205.16934-1-tomas.winkler@intel.com>
This suppresses sparse warning
drivers/char/tpm/tpm_crb.c:558:18: warning: cast to restricted __le64
Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
---
drivers/char/tpm/tpm_crb.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_crb.c b/drivers/char/tpm/tpm_crb.c
index acfcdc6f31af..29fecdea0b2d 100644
--- a/drivers/char/tpm/tpm_crb.c
+++ b/drivers/char/tpm/tpm_crb.c
@@ -489,6 +489,7 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv,
u32 pa_high, pa_low;
u64 cmd_pa;
u32 cmd_size;
+ __le64 __rsp_pa;
u64 rsp_pa;
u32 rsp_size;
int ret;
@@ -554,8 +555,8 @@ static int crb_map_io(struct acpi_device *device, struct crb_priv *priv,
goto out;
}
- memcpy_fromio(&rsp_pa, &priv->regs_t->ctrl_rsp_pa, 8);
- rsp_pa = le64_to_cpu(rsp_pa);
+ memcpy_fromio(&__rsp_pa, &priv->regs_t->ctrl_rsp_pa, 8);
+ rsp_pa = le64_to_cpu(__rsp_pa);
rsp_size = crb_fixup_cmd_size(dev, &io_res, rsp_pa,
ioread32(&priv->regs_t->ctrl_rsp_size));
--
2.14.3
next prev parent reply other threads:[~2018-03-04 12:15 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-04 12:12 [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Tomas Winkler
2018-03-04 12:12 ` [PATCH 2/3] tpm: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-03-05 13:02 ` Jarkko Sakkinen
2018-03-04 12:12 ` Tomas Winkler [this message]
2018-03-05 13:03 ` [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address Jarkko Sakkinen
2018-03-06 8:28 ` Jarkko Sakkinen
2018-03-06 8:34 ` Winkler, Tomas
2018-03-06 15:39 ` Jason Gunthorpe
2018-03-05 12:56 ` [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Jarkko Sakkinen
2018-03-05 13:09 ` Winkler, Tomas
2018-03-05 17:59 ` Jarkko Sakkinen
2018-03-05 18:04 ` Winkler, Tomas
2018-03-06 8:02 ` Jarkko Sakkinen
2018-03-06 8:09 ` Winkler, Tomas
2018-03-06 7:49 ` Jarkko Sakkinen
2018-03-06 8:06 ` Winkler, Tomas
2018-03-06 16:32 ` James Bottomley
2018-03-06 16:45 ` Winkler, Tomas
2018-03-06 18:36 ` Mimi Zohar
2018-03-06 21:59 ` Jason Gunthorpe
2018-03-07 15:22 ` Mimi Zohar
2018-03-07 15:41 ` Winkler, Tomas
2018-03-07 15:54 ` Jonathan Corbet
2018-03-07 16:04 ` Winkler, Tomas
2018-03-07 16:35 ` Mimi Zohar
2018-03-07 18:24 ` Jonathan Corbet
2018-03-10 12:46 ` Jarkko Sakkinen
2018-03-10 12:44 ` Jarkko Sakkinen
2018-03-10 12:37 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180304121205.16934-3-tomas.winkler@intel.com \
--to=tomas.winkler@intel.com \
--cc=alexander.usyskin@intel.com \
--cc=jarkko.sakkinen@linux.intel.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®