mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: "zhenwei.pi" <zhenwei.pi@youruncloud.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, hpa@zytor.com,
	mingo@redhat.com, tglx@linutronix.de
Subject: Re: [PATCH] x86/kconfig: Remove residual "no-hlt" boot parameter reference
Date: Mon, 5 Mar 2018 08:10:21 +0100	[thread overview]
Message-ID: <20180305071021.5lxgjnnwdidkq7re@gmail.com> (raw)
In-Reply-To: <1520216154-13737-1-git-send-email-zhenwei.pi@youruncloud.com>


* zhenwei.pi <zhenwei.pi@youruncloud.com> wrote:

> The "no-hlt" boot parameter has been removed ~5 years ago :
> 	The commit 27be457000211a6903968dfce06d5f73f051a217
> 	("x86 idle: remove 32-bit-only "no-hlt" parameter, hlt_works_ok flag")
> 
> Remove a stale reference from the documentation as well.
> 
> Signed-off-by: zhenwei.pi <zhenwei.pi@youruncloud.com>
> ---
>  arch/x86/Kconfig | 21 ++++++++++-----------
>  1 file changed, 10 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index eb7f43f..bdb17b7 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2494,19 +2494,18 @@ menuconfig APM
>  
>  	  1) make sure that you have enough swap space and that it is
>  	  enabled.
> -	  2) pass the "no-hlt" option to the kernel
> -	  3) switch on floating point emulation in the kernel and pass
> +	  2) switch on floating point emulation in the kernel and pass
>  	  the "no387" option to the kernel
> -	  4) pass the "floppy=nodma" option to the kernel
> -	  5) pass the "mem=4M" option to the kernel (thereby disabling
> +	  3) pass the "floppy=nodma" option to the kernel
> +	  4) pass the "mem=4M" option to the kernel (thereby disabling
>  	  all but the first 4 MB of RAM)
> -	  6) make sure that the CPU is not over clocked.
> -	  7) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
> -	  8) disable the cache from your BIOS settings
> -	  9) install a fan for the video card or exchange video RAM
> -	  10) install a better fan for the CPU
> -	  11) exchange RAM chips
> -	  12) exchange the motherboard.
> +	  5) make sure that the CPU is not over clocked.
> +	  6) read the sig11 FAQ at <http://www.bitwizard.nl/sig11/>
> +	  7) disable the cache from your BIOS settings
> +	  8) install a fan for the video card or exchange video RAM
> +	  9) install a better fan for the CPU
> +	  10) exchange RAM chips
> +	  11) exchange the motherboard.

That description is stale in other ways as well (nobody uses floppies anymore), 
I'd just remove it altogether, starting with this:

                                                                If you get
          random kernel OOPSes or reboots that don't seem to be related to
          anything, try disabling/enabling this option (or disabling/enabling
          APM in your BIOS).
	  [...]

Thanks,

	Ingo

      reply	other threads:[~2018-03-05  7:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05  2:15 zhenwei.pi
2018-03-05  7:10 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180305071021.5lxgjnnwdidkq7re@gmail.com \
    --to=mingo@kernel.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=zhenwei.pi@youruncloud.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®