From: Jeffy Chen <jeffy.chen@rock-chips.com>
To: linux-kernel@vger.kernel.org
Cc: Jeffy Chen <jeffy.chen@rock-chips.com>,
Andrzej Hajda <a.hajda@samsung.com>,
Romain Perier <romain.perier@collabora.com>,
Archit Taneja <architt@codeaurora.org>,
dri-devel@lists.freedesktop.org,
Russell King <rmk+kernel@armlinux.org.uk>,
Neil Armstrong <narmstrong@baylibre.com>,
David Airlie <airlied@linux.ie>,
Hans Verkuil <hverkuil@xs4all.nl>,
Jose Abreu <Jose.Abreu@synopsys.com>,
Jernej Skrabec <jernej.skrabec@siol.net>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>
Subject: [PATCH] drm/bridge/synopsys: dw-hdmi: Fix memleak in __dw_hdmi_remove
Date: Mon, 5 Mar 2018 15:45:55 +0800 [thread overview]
Message-ID: <20180305074555.23368-1-jeffy.chen@rock-chips.com> (raw)
The platform_device_register_full() will allocate dma_mask for
hdmi->audio, so we should free before platform_device_unregister().
Reported by kmemleak:
unreferenced object 0xffffffc0ef70ff00 (size 128):
comm "kworker/4:1", pid 123, jiffies 4294670080 (age 189.604s)
hex dump (first 32 bytes):
ff ff ff ff 00 00 00 00 00 00 00 00 00 00 00 00 ................
00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
backtrace:
[<0000000021946f44>] kmemleak_alloc+0x58/0x8c
[<000000009c43890d>] kmem_cache_alloc_memcg_trace+0x18c/0x25c
[<000000000e17cd06>] platform_device_register_full+0x64/0x108
[<00000000418a0882>] __dw_hdmi_probe+0xb9c/0xcc0
[<00000000e0b720fd>] dw_hdmi_bind+0x30/0x88
[<000000009af347f6>] dw_hdmi_rockchip_bind+0x260/0x2e8
Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index f9802399cc0d..d9afdc59d4f4 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -2567,8 +2567,10 @@ __dw_hdmi_probe(struct platform_device *pdev,
static void __dw_hdmi_remove(struct dw_hdmi *hdmi)
{
- if (hdmi->audio && !IS_ERR(hdmi->audio))
+ if (hdmi->audio && !IS_ERR(hdmi->audio)) {
+ kfree(hdmi->audio->dev.dma_mask);
platform_device_unregister(hdmi->audio);
+ }
if (!IS_ERR(hdmi->cec))
platform_device_unregister(hdmi->cec);
--
2.11.0
next reply other threads:[~2018-03-05 7:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 7:45 Jeffy Chen [this message]
2018-03-05 17:41 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305074555.23368-1-jeffy.chen@rock-chips.com \
--to=jeffy.chen@rock-chips.com \
--cc=Jose.Abreu@synopsys.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=airlied@linux.ie \
--cc=architt@codeaurora.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil@xs4all.nl \
--cc=jernej.skrabec@siol.net \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=romain.perier@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®