From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-4155484-1520330025-2-13731282534978768528 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.249, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, UNPARSEABLE_RELAY 0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520330024; b=aklm4oJU29S17Z5/icHsgq37CFgOBw+IyrtgSCbokbyDJrk PkiId5ofEH/hBhLA4+PpKEJNgamV1eRGzUFif7S1QelhVHk3xhc83UC/r55REHMt hrnG68opJzxARgQr/IoxW7yeEoP0A4cz+S7urTPNXOLm2h1jT0JfxnZC2CnGhRIi j3NWItrGZtNsGUAYw8KAkiweIjlck8QVpUAeuG3ZhN2L29sz+gY5mxAixp8cfc+j xFdRxatJphoP/lvNx557fUaZsimvkJaqRiY354tIoMQGL2NRHG+1LDQq68SryBAE 1xkpE5B6HcdVmxj2jYFwNkvIfUSJCUx6i/xV5yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1520330024; bh=V 3mGqOY3cIJWAqMUIcEyeFahKdBgMGoTAE6hqBA6wWo=; b=LVbd7HFIj/t+qSZeY LI9FxZ1+cvK37kOVgMt1Btce1j0kLZ0AIRuysYG5QnBnddkO111iAP2g2NqKEOeL tfe4O31yu3YL9z701rrwLgR8DegBBitbbSnuy5OVLZiwgkoSGwUZc347Kk4AIPpK lM8AvseSbaC3kAKKCnqZrXhKyZmfQR988/PI1Dv/z5ej7WyTMaOHg0J+6hdlELeF XJhf5+jR1fhLZpU1fXsTszbg7u3HpJKbsjXOztui8562iH0D9Bt+lQ6newtlsm75 v6l6+BdR6ULv3EJGn7wHm4mtOZgtoNeYmjJipu8/M1oxio61bZH5/PmUamrHtSrn k9Flw== ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=lH9qA9sF x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=lH9qA9sF x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Tue, 6 Mar 2018 12:53:20 +0300 From: Dan Carpenter To: Arushi Singhal Subject: Re: [PATCH] staging: irda: Replace printk() with appropriate net_*macro_ratelimited() Message-ID: <20180306095320.2v63xokda4wsirwg@mwanda> References: <20180304223205.GA31416@seema-Inspiron-15-3567> <20180305100345.v6ajs7vdgzmwu5x4@mwanda> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8823 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803060114 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: driverdevel , Greg KH , LKML , outreachy-kernel@googlegroups.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Mon, Mar 05, 2018 at 11:41:43PM +0530, Arushi Singhal wrote: > On Mon, Mar 5, 2018 at 3:33 PM, Dan Carpenter > wrote: > > > On Mon, Mar 05, 2018 at 04:02:06AM +0530, Arushi Singhal wrote: > > > Replace printk having a log level with the appropriate > > > net_*macro_ratelimited. > > > It's better to use actual device name as a prefix in error messages. > > > Indentation is also changed, to fix the checkpatch issue if line is not > > > exceding 80 characters. > > > > > > Signed-off-by: Arushi Singhal > > > --- > > > .../rtl8192u/ieee80211/ieee80211_crypt_ccmp.c | 22 > > +++++++++++----------- > > > 1 file changed, 11 insertions(+), 11 deletions(-) > > > > > > diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c > > b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c > > > index e6648f7..200fe5f 100644 > > > --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c > > > +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_ccmp.c > > > @@ -73,7 +73,7 @@ static void *ieee80211_ccmp_init(int key_idx) > > > > > > priv->tfm = (void *)crypto_alloc_cipher("aes", 0, > > CRYPTO_ALG_ASYNC); > > > if (IS_ERR(priv->tfm)) { > > > - printk(KERN_DEBUG "ieee80211_crypt_ccmp: could not > > allocate crypto API aes\n"); > > > + net_dbg_ratelimited("ieee80211_crypt_ccmp: could not > > allocate crypto API aes\n"); > > > > > > This should probably just be deleted. > > > Hello Dan > Why we should make this change? > According to me it's use here to print debug message. > Wanted to know more about your thought on this. Actually, I looked at this wrong. I though that crypto_alloc_cipher() had its own error messages. Sorry about that. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel