From: Ioana Radulescu <ruxandra.radulescu@nxp.com>
To: gregkh@linuxfoundation.org
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
roy.pledge@nxp.com, laurentiu.tudor@nxp.com
Subject: [PATCH 4/5] staging: fsl-mc/dpio: Fix incorrect masking
Date: Tue, 6 Mar 2018 11:43:47 -0600 [thread overview]
Message-ID: <20180306174348.26095-5-ruxandra.radulescu@nxp.com> (raw)
In-Reply-To: <20180306174348.26095-1-ruxandra.radulescu@nxp.com>
In qbman_swp_alt_fq_state(), we need to mask the fqid value
before converting it to little endian, otherwise we write a
wrong value to hardware when running in big endian mode.
Signed-off-by: Ioana Radulescu <ruxandra.radulescu@nxp.com>
---
drivers/staging/fsl-mc/bus/dpio/qbman-portal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
index 377f4d9..7e55b56 100644
--- a/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
+++ b/drivers/staging/fsl-mc/bus/dpio/qbman-portal.c
@@ -927,7 +927,7 @@ int qbman_swp_alt_fq_state(struct qbman_swp *s, u32 fqid,
if (!p)
return -EBUSY;
- p->fqid = cpu_to_le32(fqid) & ALT_FQ_FQID_MASK;
+ p->fqid = cpu_to_le32(fqid & ALT_FQ_FQID_MASK);
/* Complete the management command */
r = qbman_swp_mc_complete(s, p, alt_fq_verb);
--
2.7.4
next prev parent reply other threads:[~2018-03-06 17:43 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 17:43 [PATCH 0/5] staging: fsl-mc/dpio: Fix sparse warnings Ioana Radulescu
2018-03-06 17:43 ` [PATCH 1/5] staging: fsl-mc/dpio: Fix incorrect cast Ioana Radulescu
2018-03-06 17:43 ` [PATCH 2/5] staging: fsl-mc/dpio: Fix cast truncate warning Ioana Radulescu
2018-03-06 17:43 ` [PATCH 3/5] staging: fsl-mc/dpio: Use __leXX types where needed Ioana Radulescu
2018-03-06 17:43 ` Ioana Radulescu [this message]
2018-03-06 17:43 ` [PATCH 5/5] staging: fsl-mc/dpio: Remove dead code Ioana Radulescu
2018-03-06 18:32 ` Ruxandra Ioana Ciocoi Radulescu
2018-03-08 17:58 ` gregkh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180306174348.26095-5-ruxandra.radulescu@nxp.com \
--to=ruxandra.radulescu@nxp.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurentiu.tudor@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roy.pledge@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®