mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, Lars-Peter Clausen <lars@metafoo.de>,
	linux-iio@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	Hartmut Knaack <knaack.h@gmx.de>,
	daniel.baluta@nxp.com, Jonathan Cameron <jic23@kernel.org>
Subject: Re: [PATCH 3/3] staging:iio:meter: Aligns open parenthesis
Date: Tue, 6 Mar 2018 17:21:38 -0300	[thread overview]
Message-ID: <20180306202138.dquhxpfiwq6matbe@smtp.gmail.com> (raw)
In-Reply-To: <20180306135314.vxngtgj6yxomasm2@mwanda>

Hi

On 03/06, Dan Carpenter wrote:
> On Tue, Mar 06, 2018 at 09:26:07AM -0300, Rodrigo Siqueira wrote:
> > @@ -63,7 +63,7 @@ int ade7758_probe_trigger(struct iio_dev *indio_dev)
> >  	int ret;
> >  
> >  	st->trig = iio_trigger_alloc("%s-dev%d",
> > -					spi_get_device_id(st->us)->name,
> > +				     spi_get_device_id(st->us)->name,
> >  					indio_dev->id);
>                                         ^^^^^^^^^^^^^
> The "indio_dev->id" needs to be aligned as well.

I will fix it and send a v2.

Thanks for the review!
 
> >  	if (!st->trig) {
> >  		ret = -ENOMEM;
> 
> regards,
> dan carpenter
> 
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

      reply	other threads:[~2018-03-06 20:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06 12:25 [PATCH 0/3] staging:iio:meter: Checkpatch cleanup for meter Rodrigo Siqueira
2018-03-06 12:25 ` [PATCH 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR Rodrigo Siqueira
2018-03-06 12:25 ` [PATCH 2/3] staging:iio:meter: Remove unused macro IIO_DEV_ATTR_CH_OFF Rodrigo Siqueira
2018-03-06 12:26 ` [PATCH 3/3] staging:iio:meter: Aligns open parenthesis Rodrigo Siqueira
2018-03-06 13:53   ` Dan Carpenter
2018-03-06 20:21     ` Rodrigo Siqueira [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180306202138.dquhxpfiwq6matbe@smtp.gmail.com \
    --to=rodrigosiqueiramelo@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=daniel.baluta@nxp.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome