mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: changbin.du@intel.com
Cc: acme@kernel.org, jolsa@redhat.com, peterz@infradead.org,
	mingo@redhat.com, linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org, kernel-team@lge.com
Subject: Re: [PATCH v2 1/2] perf sched: move thread::shortname to thread_runtime
Date: Wed, 7 Mar 2018 11:44:41 +0900	[thread overview]
Message-ID: <20180307024441.GA10527@danjae.aot.lge.com> (raw)
In-Reply-To: <1520307457-23668-2-git-send-email-changbin.du@intel.com>

Hi,

On Tue, Mar 06, 2018 at 11:37:36AM +0800, changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
> 
> The thread::shortname only used by sched command, so move it
> to sched private structure.
> 
> Signed-off-by: Changbin Du <changbin.du@intel.com>
> ---

[SNIP]
> diff --git a/tools/perf/util/thread.h b/tools/perf/util/thread.h
> index 40cfa36..14d44c3 100644
> --- a/tools/perf/util/thread.h
> +++ b/tools/perf/util/thread.h
> @@ -26,7 +26,6 @@ struct thread {
>  	pid_t			ppid;
>  	int			cpu;
>  	refcount_t		refcnt;
> -	char			shortname[3];
>  	bool			comm_set;
>  	int			comm_len;
>  	bool			dead; /* if set thread has exited */

I also suggest to move the 'dead' field to pack two bools.

Thanks,
Namhyung

  parent reply	other threads:[~2018-03-07  2:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-06  3:37 [PATCH v2 0/2] perf sched map: re-annotate shortname if thread comm changed changbin.du
2018-03-06  3:37 ` [PATCH v2 1/2] perf sched: move thread::shortname to thread_runtime changbin.du
2018-03-06 14:09   ` Arnaldo Carvalho de Melo
2018-03-07  2:44   ` Namhyung Kim [this message]
2018-03-09  8:37   ` [tip:perf/core] perf sched: Move " tip-bot for Changbin Du
2018-03-06  3:37 ` [PATCH v2 2/2] perf sched map: re-annotate shortname if thread comm changed changbin.du
2018-03-09  8:37   ` [tip:perf/core] perf sched map: Re-annotate " tip-bot for Changbin Du
2018-03-06  7:53 ` [PATCH v2 0/2] perf sched map: re-annotate " Jiri Olsa
2018-03-06 14:17   ` Arnaldo Carvalho de Melo
2018-03-07  2:28     ` Du, Changbin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307024441.GA10527@danjae.aot.lge.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=changbin.du@intel.com \
    --cc=jolsa@redhat.com \
    --cc=kernel-team@lge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome