mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gioh Kim <gi-oh.kim@profitbricks.com>
To: linux-kernel@vger.kernel.org, kstewart@linuxfoundation.org,
	tglx@linutronix.de, pombredanne@nexb.com,
	gregkh@linuxfoundation.org
Cc: Gioh Kim <gi-oh.kim@profitbricks.com>
Subject: [PATCH] setlocalversion: use any tag
Date: Wed,  7 Mar 2018 10:34:03 +0100	[thread overview]
Message-ID: <20180307093403.19610-1-gi-oh.kim@profitbricks.com> (raw)

I googled about '+' mark in kernel version number. Many people also
do not understand why their kernel version includes '+'. And many
people creates an empty .scmversion file to remove it. I also
create the empty .scmversion file whenever I clean the kernel tree.
If setlocalversion script uses both of annotated tag and
lightweight tag, it would be more convenient because it is common to set
lightweight tag during developmene process.

Signed-off-by: Gioh Kim <gi-oh.kim@profitbricks.com>
---
 scripts/setlocalversion | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/scripts/setlocalversion b/scripts/setlocalversion
index 71f39410691b..9f4309697ea6 100755
--- a/scripts/setlocalversion
+++ b/scripts/setlocalversion
@@ -49,7 +49,7 @@ scm_version()
 
 		# If we are at a tagged commit (like "v2.6.30-rc6"), we ignore
 		# it, because this version is defined in the top level Makefile.
-		if [ -z "`git describe --exact-match 2>/dev/null`" ]; then
+		if [ -z "`git describe --exact-match --tags 2>/dev/null`" ]; then
 
 			# If only the short version is requested, don't bother
 			# running further git commands
-- 
2.14.1

                 reply	other threads:[~2018-03-07  9:34 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307093403.19610-1-gi-oh.kim@profitbricks.com \
    --to=gi-oh.kim@profitbricks.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kstewart@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pombredanne@nexb.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®