From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-2943591-1520419681-2-16289392948301957108 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_MED -2.3, SPF_PASS -0.001, UNPARSEABLE_RELAY 0.001, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='140.211.166.138', Host='smtp1.osuosl.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: plain='us-ascii' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: driverdev-devel-bounces@linuxdriverproject.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520419681; b=GeOl9Q9Vur63oLm6jrKZKcy/ALg3DOuP8cwe3XHzPgGvrcL LfBdvCkbedpcKK3DWMlsIM2tz/H6J321g634DeY+71440f29yCzpx7p1mP6u6pKv eoLXtD3/6RjN0YonEBBNBiPoeShgWYh8Oxxspwpk3xLjC09UD+QaiwspkSbEM6oR IzYpWLJhvQH+Djg9V+Z46FEpxapeRCsSj/b2GnSU01kJX5NCcv6oXBbLoKLu8pkk uaRwKVJEMGjchXLQXACideKyCRzvhDHEGc975FPpkMz/6lRnVQQ/HjIGZrD2RY1G AAmqejoKsKemysASc66nOk2oXMyE/mYd6X7uZRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:to:subject:message-id :references:mime-version:in-reply-to:list-id:list-unsubscribe :list-archive:list-post:list-help:list-subscribe:cc:content-type :content-transfer-encoding:sender; s=arctest; t=1520419681; bh=k jyOa78rbUmHE7Daq5w2AAitzv3xPz0oikY/jyJLHkA=; b=t5N8CbMz/HEtK6Hm/ DgGKqEPCuzC7jWQK8GEjhylR+6p1fo6iFIRaNFRrKQcLDFNgfjcx1wn4eeiOg7Va YCYv2sprTdfS3jbNQnOrz1PyAMQRdpPhRFaJs8PJQrOi/AKVfMgrtB7M4EK2ieMv h6tU1Wx04k8AvyoOWD+F7q1FQLgM5htp5qdKXLTbiRB5JCfhLDfxu0uaCHa0yYoE wTrI1vXpHDSq/iV8WR9582c487pDeH3saO5s7kAMPMI1ZINluSTTok01aISxxNcb u4UNj4v/CrXN0RzpVKGC9sntBs8GguZ64xMMha8zmuZykBRPpMCXOzRQDvawn8if uqTEg== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=T9dN2XK7 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=fail (message has been altered; 2048-bit rsa key sha256) header.d=oracle.com header.i=@oracle.com header.b=T9dN2XK7 x-bits=2048 x-keytype=rsa x-algorithm=sha256 x-selector=corp-2017-10-26; dmarc=fail (p=none,has-list-id=yes,d=none) header.from=oracle.com; iprev=pass policy.iprev=140.211.166.138 (smtp1.osuosl.org); spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org smtp.helo=whitealder.osuosl.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=fail x-ptr-helo=whitealder.osuosl.org x-ptr-lookup=smtp1.osuosl.org; x-return-mx=pass smtp.domain=linuxdriverproject.org smtp.result=pass smtp_is_org_domain=yes header.domain=oracle.com header.result=pass header_is_org_domain=yes; x-tls=pass version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128 X-Remote-Delivered-To: driverdev-devel@osuosl.org Date: Wed, 7 Mar 2018 13:47:41 +0300 From: Dan Carpenter To: Arushi Singhal Subject: Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format. Message-ID: <20180307104741.mdy2wa7hplfwxmb3@mwanda> References: <20180307103908.GA19612@seema-Inspiron-15-3567> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180307103908.GA19612@seema-Inspiron-15-3567> User-Agent: NeoMutt/20170609 (1.8.3) X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8824 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=947 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1711220000 definitions=main-1803070125 X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.24 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote: > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv) > keyidx = pos[3]; > if (!(keyidx & (1 << 5))) { > if (net_ratelimit()) { > - printk(KERN_DEBUG "CCMP: received packet without ExtIV flag from %pM\n", > - hdr->addr2); > + netdev_dbg(skb->dev, "CCMP: received packet without ExtIV flag from %pM\n", > + hdr->addr2); > } I'm sorry. I really hate to do this to you... But the right thing here is to use net_dbg_ratelimited() but get rid of the if (net_ratelimit()) check. So it looks like this: if (!(keyidx & (1 << 5))) { net_dbg_ratelimited(skb->dev, "CCMP: received packet without ExtIV flag from %pM\n", hdr->addr2); } Sorry again, when I looked at it before I just replied what my fast thinking lizard brain said instead of taking time to look at what I was saying. regards, dan carpenter _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel