From: Dan Carpenter <dan.carpenter@oracle.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: Arushi Singhal <arushisinghal19971997@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [Outreachy kernel] Re: [PATCH v3] staging: rtl8192u: Replace printk() with more standardize output format.
Date: Wed, 7 Mar 2018 14:01:59 +0300 [thread overview]
Message-ID: <20180307110159.gnetxajp4c7oz52x@mwanda> (raw)
In-Reply-To: <alpine.DEB.2.20.1803071151080.3361@hadrien>
On Wed, Mar 07, 2018 at 11:52:16AM +0100, Julia Lawall wrote:
>
>
> On Wed, 7 Mar 2018, Dan Carpenter wrote:
>
> > On Wed, Mar 07, 2018 at 04:09:09PM +0530, Arushi Singhal wrote:
> > > @@ -276,22 +276,22 @@ static int ieee80211_ccmp_decrypt(struct sk_buff *skb, int hdr_len, void *priv)
> > > keyidx = pos[3];
> > > if (!(keyidx & (1 << 5))) {
> > > if (net_ratelimit()) {
> > > - printk(KERN_DEBUG "CCMP: received packet without ExtIV flag from %pM\n",
> > > - hdr->addr2);
> > > + netdev_dbg(skb->dev, "CCMP: received packet without ExtIV flag from %pM\n",
> > > + hdr->addr2);
> > > }
> >
> > I'm sorry. I really hate to do this to you... But the right thing here
> > is to use net_dbg_ratelimited() but get rid of the if (net_ratelimit())
> > check. So it looks like this:
> >
> > if (!(keyidx & (1 << 5))) {
> > net_dbg_ratelimited(skb->dev,
> > "CCMP: received packet without ExtIV flag from %pM\n",
> > hdr->addr2);
> > }
> >
> > Sorry again, when I looked at it before I just replied what my fast
> > thinking lizard brain said instead of taking time to look at what I was
> > saying.
>
> I don't think that net_dbg_ratelimited wants a skb->dev argument. The
> various definitions in include/linux/net.h just have fmt as the first
> argument.
>
Ah.... That's fine then. Don't worry about it.
regards,
dan carpenter
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-03-07 11:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 10:39 Arushi Singhal
2018-03-07 10:47 ` Dan Carpenter
2018-03-07 10:52 ` [Outreachy kernel] " Julia Lawall
2018-03-07 11:01 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307110159.gnetxajp4c7oz52x@mwanda \
--to=dan.carpenter@oracle.com \
--cc=arushisinghal19971997@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®