From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933335AbeCGPM6 (ORCPT ); Wed, 7 Mar 2018 10:12:58 -0500 Received: from mail-wr0-f196.google.com ([209.85.128.196]:42288 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754683AbeCGPM4 (ORCPT ); Wed, 7 Mar 2018 10:12:56 -0500 X-Google-Smtp-Source: AG47ELsm/IzpuowsQzwYC/Kp37g7vwOThWxcR2MdRDE6rshYdGNuIf0tBzLH01SpOdDcxutbjviXJQ== Date: Wed, 7 Mar 2018 15:12:53 +0000 From: Lee Jones To: Enric Balletbo i Serra Cc: groeck@chromium.org, gwendal@chromium.org, bleung@chromium.org, linux-kernel@vger.kernel.org, kernel@collabora.com, Vincent Palatin Subject: Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC Message-ID: <20180307151253.pytqvo55svirgc6z@dell> References: <20180219224602.22582-1-enric.balletbo@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180219224602.22582-1-enric.balletbo@collabora.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote: > From: Vincent Palatin > > If we cannot communicate with the EC chip to detect the protocol version > and its features, it's very likely useless to continue. Else we will > commit all kind of uninformed mistakes (using the wrong protocol, the > wrong buffer size, mixing the EC with other chips). > > Signed-off-by: Vincent Palatin > Acked-by: Benson Leung > Signed-off-by: Enric Balletbo i Serra > --- > drivers/mfd/cros_ec.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) Unless it is my mailer that is playing up, it looks as though you have sent this set un-threaded, which means that when others or myself start replying to them one-by-one, they will be sprawled throughout my inbox. It also seems as though there is no 0th (cover letter) patch, which means I am lacking potentially important information regarding the history of the set and what you are trying to achieve. Anyway, the patch has been applied this time (hopefully there aren't any inter-dependencies. -- Lee Jones Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog