From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: groeck@chromium.org, gwendal@chromium.org, bleung@chromium.org,
linux-kernel@vger.kernel.org, kernel@collabora.com,
Vincent Palatin <vpalatin@chromium.org>
Subject: Re: [PATCH 1/6] mfd: cros_ec: fail early if we cannot identify the EC
Date: Wed, 7 Mar 2018 15:18:31 +0000 [thread overview]
Message-ID: <20180307151831.u65fryr4e7mbdwpe@dell> (raw)
In-Reply-To: <20180307151253.pytqvo55svirgc6z@dell>
On Wed, 07 Mar 2018, Lee Jones wrote:
> On Mon, 19 Feb 2018, Enric Balletbo i Serra wrote:
>
> > From: Vincent Palatin <vpalatin@chromium.org>
> >
> > If we cannot communicate with the EC chip to detect the protocol version
> > and its features, it's very likely useless to continue. Else we will
> > commit all kind of uninformed mistakes (using the wrong protocol, the
> > wrong buffer size, mixing the EC with other chips).
> >
> > Signed-off-by: Vincent Palatin <vpalatin@chromium.org>
> > Acked-by: Benson Leung <bleung@chromium.org>
> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> > ---
> > drivers/mfd/cros_ec.c | 6 +++++-
> > 1 file changed, 5 insertions(+), 1 deletion(-)
>
> Unless it is my mailer that is playing up, it looks as though you have
> sent this set un-threaded, which means that when others or myself
> start replying to them one-by-one, they will be sprawled throughout my
> inbox. It also seems as though there is no 0th (cover letter) patch,
> which means I am lacking potentially important information regarding
> the history of the set and what you are trying to achieve.
>
> Anyway, the patch has been applied this time (hopefully there aren't
> any inter-dependencies.
As discussed in 2/6, I'm going to un-apply this.
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2018-03-07 15:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-19 22:46 Enric Balletbo i Serra
2018-02-21 23:52 ` Gwendal Grignou
2018-03-07 15:12 ` Lee Jones
2018-03-07 15:18 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307151831.u65fryr4e7mbdwpe@dell \
--to=lee.jones@linaro.org \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vpalatin@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®