mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Avi Fishman <avifishman70@gmail.com>, Tomer Maimon <tmaimon77@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
	Patrick Venture <venture@google.com>,
	Nancy Yuen <yuenn@google.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	linux-arm-kernel@lists.infradead.org, openbmc@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements
Date: Wed,  7 Mar 2018 17:24:13 +0100	[thread overview]
Message-ID: <20180307162430.2664523-2-arnd@arndb.de> (raw)
In-Reply-To: <20180307162430.2664523-1-arnd@arndb.de>

While looking at the build regression, I noticed that the
platform selects a lot of other Kconfig symbols that it really
should not:

CPU_V7, ARM_GIC, HAVE_SMP, COMMON_CLK, GENERIC_CLOCKEVENTS,
and CLKDEV_LOOKUP are all implied by ARCH_MULTI_V7, so they
can be dropped.

CACHE_L2X0, SMP and USB are meant to be user-selectable, we
want to be able to turn those off for testing purposes.

CPU_USE_DOMAINS looks completely misplaced here, we should not
select that for an ARMv7 platform.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 arch/arm/mach-npcm/Kconfig | 18 ------------------
 1 file changed, 18 deletions(-)

diff --git a/arch/arm/mach-npcm/Kconfig b/arch/arm/mach-npcm/Kconfig
index 2bc6697c8d97..c6a16230e8ef 100644
--- a/arch/arm/mach-npcm/Kconfig
+++ b/arch/arm/mach-npcm/Kconfig
@@ -12,12 +12,6 @@ comment "NPCM7XX CPU type"
 config ARCH_NPCM750
 	depends on ARCH_NPCM
 	bool "Support for NPCM750 BMC CPU (Poleg)"
-	select CACHE_L2X0
-	select CPU_V7
-	select ARM_GIC
-	select HAVE_SMP
-	select SMP
-	select SMP_ON_UP
 	select HAVE_ARM_SCU
 	select HAVE_ARM_TWD if SMP
 	select ARM_ERRATA_720789
@@ -26,18 +20,6 @@ config ARCH_NPCM750
 	select ARM_ERRATA_794072
 	select PL310_ERRATA_588369
 	select PL310_ERRATA_727915
-	select USB_EHCI_ROOT_HUB_TT
-	select USB_ARCH_HAS_HCD
-	select USB_ARCH_HAS_EHCI
-	select USB_EHCI_HCD
-	select USB_ARCH_HAS_OHCI
-	select USB_OHCI_HCD
-	select USB
-	select FIQ
-	select CPU_USE_DOMAINS
-	select GENERIC_CLOCKEVENTS
-	select CLKDEV_LOOKUP
-	select COMMON_CLK if OF
 	select NPCM750_TIMER
 	select MFD_SYSCON
 	help
-- 
2.9.0

  reply	other threads:[~2018-03-07 16:25 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-07 16:24 [PATCH 1/2] ARM: npcm: add CONFIG_ARCH_MULTI_V7 dependency Arnd Bergmann
2018-03-07 16:24 ` Arnd Bergmann [this message]
2018-03-08  2:12   ` [PATCH 2/2] ARM: npcm: drop extraneous 'select' statements Joel Stanley
2018-03-08 10:46     ` Avi Fishman
2018-03-08 10:51       ` Arnd Bergmann
2018-03-12 10:16   ` Tomer Maimon
2018-03-12 11:43     ` Tomer Maimon
2018-03-12 12:43       ` Arnd Bergmann
2018-03-09  2:08 ` [PATCH 1/2] ARM: npcm: add CONFIG_ARCH_MULTI_V7 dependency Brendan Higgins
2018-03-12 13:28   ` Tomer Maimon
2018-03-12 13:37     ` Arnd Bergmann
2018-03-12 15:15       ` Tomer Maimon
2018-03-13 13:35         ` Tomer Maimon
2018-03-13 16:23           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307162430.2664523-2-arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=avifishman70@gmail.com \
    --cc=brendanhiggins@google.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openbmc@lists.ozlabs.org \
    --cc=tmaimon77@gmail.com \
    --cc=venture@google.com \
    --cc=yuenn@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®