From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: Benson Leung <bleung@chromium.org>,
linux-kernel@vger.kernel.org, kernel@collabora.com,
groeck@chromium.org, gwendal@chromium.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v2 6/6] platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle
Date: Wed, 7 Mar 2018 16:28:46 +0000 [thread overview]
Message-ID: <20180307162846.6he3rtvtzkvuwpem@dell> (raw)
In-Reply-To: <20180221170748.27505-7-enric.balletbo@collabora.com>
On Wed, 21 Feb 2018, Enric Balletbo i Serra wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
>
> This adds a sysfs attribute (/sys/class/chromeos/cros_ec/kb_wake_angle)
> used to set and get the keyboard wake lid angle. This attribute is
> present only if 2 accelerometers are controlled by the EC.
>
> This patch also moves the cros_ec features check before the device is
> added so the features map obtained from the EC is ready on time.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> Changes since v1:
> - Suggested by Andy Shevchenko:
> - Use the previous defined to_cros_ec_dev
> - Use one line when fits in 80 characters.
> - Use DEVICE_ATTR_RW variant.
>
> drivers/platform/chrome/cros_ec_sysfs.c | 81 +++++++++++++++++++++++++++++++++
> drivers/mfd/cros_ec_dev.c | 19 ++++----
> include/linux/mfd/cros_ec.h | 1 +
Please send me a PR with this patch contained.
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-03-07 16:28 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-21 17:07 [PATCH v2 0/6] platform/chrome: cros_ec debugfs and sysfs updates Enric Balletbo i Serra
2018-02-21 17:07 ` [PATCH v2 1/6] platform/chrome: cros_ec_sysfs: Modify error handling Enric Balletbo i Serra
2018-02-21 23:59 ` Gwendal Grignou
2018-02-21 17:07 ` [PATCH v2 2/6] platform/chrome: cros_ec_sysfs: introduce to_cros_ec_dev define Enric Balletbo i Serra
2018-02-21 19:04 ` Andy Shevchenko
2018-02-21 17:07 ` [PATCH v2 3/6] platform/chrome: cros_ec_sysfs: use permission-specific DEVICE_ATTR variants Enric Balletbo i Serra
2018-02-21 19:06 ` Andy Shevchenko
2018-02-21 17:07 ` [PATCH v2 4/6] platform/chrome: cros_ec_debugfs: Use octal permissions '0444' Enric Balletbo i Serra
2018-02-21 17:07 ` [PATCH v2 5/6] platform/chrome: cros_ec_debugfs: Add PD port info to debugfs Enric Balletbo i Serra
2018-03-01 0:26 ` kbuild test robot
2018-03-01 1:02 ` kbuild test robot
2018-02-21 17:07 ` [PATCH v2 6/6] platform/chrome: mfd/cros_ec_dev: Add sysfs entry to set keyboard wake lid angle Enric Balletbo i Serra
2018-03-07 16:28 ` Lee Jones [this message]
2018-03-17 5:31 ` Gwendal Grignou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307162846.6he3rtvtzkvuwpem@dell \
--to=lee.jones@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=bleung@chromium.org \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=kernel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®