From: Lee Jones <lee.jones@linaro.org>
To: Mark Brown <broonie@kernel.org>
Cc: JeffyChen <jeffy.chen@rock-chips.com>,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v2 1/3] mfd: syscon: Set name of regmap_config
Date: Wed, 7 Mar 2018 16:54:05 +0000 [thread overview]
Message-ID: <20180307165405.ltuobrr53vko4do7@dell> (raw)
In-Reply-To: <20180307105731.GB7290@sirena.org.uk>
On Wed, 07 Mar 2018, Mark Brown wrote:
> On Wed, Mar 07, 2018 at 06:50:08PM +0800, JeffyChen wrote:
>
> > so i sent this patch to fix that by using the of_node name to create
> > debugfs.
>
> > but later i found we have:
> > commit a430ab205d29e7d1537b220fcf989b8080d8267f
> > Author: Fabio Estevam <fabio.estevam@nxp.com>
> > Date: Mon Mar 5 15:52:09 2018 -0300
>
> > regmap: debugfs: Disambiguate dummy debugfs file name
>
> > which would fix that in another way by naming dummy0, dummy1, dummy2.
>
> > even if the issue is fixed, i wonder could we still have this patch to make
> > it more readable:
>
> Yes, like I say I think that's a good idea anyway - that sort of usage
> is the reason we've got the facility to set an explicit name.
Is that an Ack?
--
Lee Jones
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-03-07 16:54 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 11:04 Jeffy Chen
2018-03-06 11:04 ` [PATCH v2 2/3] regmap: debugfs: Fix kmemleak in regmap_debugfs_init Jeffy Chen
2018-03-06 12:59 ` Mark Brown
2018-03-07 10:56 ` JeffyChen
2018-03-06 11:04 ` [PATCH v2 3/3] regmap: debugfs: Free map->debugfs_name when debugfs_create_dir() failed Jeffy Chen
2018-03-07 14:15 ` Applied "regmap: debugfs: Free map->debugfs_name when debugfs_create_dir() failed" to the regmap tree Mark Brown
2018-03-06 14:58 ` [PATCH v2 1/3] mfd: syscon: Set name of regmap_config JeffyChen
2018-03-07 10:20 ` Mark Brown
2018-03-07 10:50 ` JeffyChen
2018-03-07 10:57 ` Mark Brown
2018-03-07 16:54 ` Lee Jones [this message]
2018-03-07 16:57 ` Mark Brown
2018-03-12 14:07 ` Lee Jones
2018-03-12 16:11 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180307165405.ltuobrr53vko4do7@dell \
--to=lee.jones@linaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®