From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934701AbeCHC5y (ORCPT ); Wed, 7 Mar 2018 21:57:54 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:42663 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934553AbeCHC5x (ORCPT ); Wed, 7 Mar 2018 21:57:53 -0500 X-Google-Smtp-Source: AG47ELu70I9YW4P4NLpJEjqj0dei86GIu26fr68PEJo2mNAsLezTiiMsdxNtTKS9uZOrR2AqhCpnmg== Date: Thu, 8 Mar 2018 10:57:40 +0800 From: Wang YanQing To: acme@kernel.org Cc: peterz@infradead.org, mingo@redhat.com, jolsa@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org Subject: [PATCH v2] perf report: Provide libtraceevent with a kernel symbol resolver Message-ID: <20180308025740.GA11469@udknight-ThinkPad-E550> Mail-Followup-To: Wang YanQing , acme@kernel.org, peterz@infradead.org, mingo@redhat.com, jolsa@redhat.com, alexander.shishkin@linux.intel.com, linux-kernel@vger.kernel.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org So that beautifiers wanting to resolve kernel function addresses to names can do its work, and when we use "perf report" for output of "perf kmem record", we will get kernel symbol output. This patch affect the output of "perf report" for the record data generated by "perf kmem record" looks like below: Before patch: 0.01% call_site=ffffffff814e5828 ptr=0x99bb000 bytes_req=3616 bytes_alloc=4096 gfp_flags=GFP_ATOMIC 0.01% call_site=ffffffff81370b87 ptr=0x428a3060 bytes_req=32 bytes_alloc=32 gfp_flags=GFP_KERNEL|GFP_ZERO After patch: 0.01% (aa_alloc_task_context+0x27) call_site=ffffffff81370b87 ptr=0x428a3060 bytes_req=32 bytes_alloc=32 gfp_flags=GFP_KERNEL|GFP_ZERO 0.01% (__tty_buffer_request_room+0x88) call_site=ffffffff814e5828 ptr=0x99bb000 bytes_req=3616 bytes_alloc=4096 gfp_flags=GFP_ATOMIC Signed-off-by: Wang YanQing Acked-by: Jiri Olsa --- Changes v1-v2: 1: Add a before and after output of tools affected by the patch in the changelog. 2: Rebase the patch to last kernel version. tools/perf/builtin-report.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index 1eedb18..d866398 100644 --- a/tools/perf/builtin-report.c +++ b/tools/perf/builtin-report.c @@ -1337,6 +1337,14 @@ int cmd_report(int argc, const char **argv) report.range_num = 1; } + if (session->tevent.pevent && + pevent_set_function_resolver(session->tevent.pevent, + machine__resolve_kernel_addr, + &session->machines.host) < 0) { + pr_err("%s: failed to set libtraceevent function resolver\n", __func__); + return -1; + } + sort__setup_elide(stdout); ret = __cmd_report(&report); -- 1.8.5.6.2.g3d8a54e.dirty