From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-1084890-1520489586-2-4334870369018846223 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.25, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='CN', FromHeader='com', MailFrom='org', XOriginatingCountry='US' X-Spam-charsets: plain='iso-8859-1' X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=arctest; t=1520489586; b=R4jIBsixM6T3t19PbFQJEU5PuD04KRBbduX7zwpGcC3P6A5 ikgqsqYw7bsYBlDrk97q9ETb+RPwH/xgkoYF0BawSb9jXVp5b/k+wwrGc74qMks/ gLAO9glOpx95UBUIoYgSAGlaxxqHEFLWoPqxbtuld9AuWhiIzODWZRWMza4onmUS jGrxKqUVqv7yic7WTVPY5eQPp9dN5jDVBgpZz93qecqKlwVqltuJFOl2TJo56bD2 vHufK869T01hOkw2aXn2ybAZDfd6BjEti6r1Owk5LvY+eif7ETZRT26WTnZ6yazr 9GquRSacvvqKetYLpohoNWUZJTnd6BVil76EImQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=from:to:cc:subject:date:message-id :references:in-reply-to:content-type:content-transfer-encoding :mime-version:sender:list-id; s=arctest; t=1520489586; bh=KwyyYd VgICZSYM8X3wXHwQEfoMl4kS8MQkUBJvIsYXk=; b=HZY+83gsm187KNGjE21Fn3 RRT4eXSrNjtMYDZyP3a/hoccx6ILcYBfkc7vJ2y0CyrAmYRyp72yTZzEvlukiPDr W6NBlZUoP5z0kKiUuK6Wad6u5eud19qrEId7Of+PoFdEVzC8CIJscQH10tO1Nv3N Ot4cCeH4QViqPYOw2/1ZS69SphRD+PEZUPBjCcvMhijbUR1EVHVlZfPhNPxYhVbj mW6MUZIltX3KvDhIQP5XFdR/Ieh7oRrjTmPTifYGyFAlrUi9fm0lsVeyCsysLalV QwEIfSnbdlkdVWRAki0bEdjHELs58VLOxDrpO582dZVldYHCQ8FPp/vq76ZVa5IQ == ARC-Authentication-Results: i=1; mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=EIIRSYSO x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Authentication-Results: mx3.messagingengine.com; arc=none (no signatures found); dkim=pass (1024-bit rsa key sha256) header.d=microsoft.com header.i=@microsoft.com header.b=EIIRSYSO x-bits=1024 x-keytype=rsa x-algorithm=sha256 x-selector=selector1; dmarc=pass (p=reject,has-list-id=yes,d=none) header.from=microsoft.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-category=clean score=-100 state=0; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=microsoft.com header.result=pass header_is_org_domain=yes Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965404AbeCHGL6 (ORCPT ); Thu, 8 Mar 2018 01:11:58 -0500 Received: from mail-dm3nam03on0125.outbound.protection.outlook.com ([104.47.41.125]:20160 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S965695AbeCHFBg (ORCPT ); Thu, 8 Mar 2018 00:01:36 -0500 From: Sasha Levin To: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" CC: Dan Carpenter , Ulf Hansson , Sasha Levin Subject: [PATCH AUTOSEL for 4.9 078/190] mmc: host: omap_hsmmc: checking for NULL instead of IS_ERR() Thread-Topic: [PATCH AUTOSEL for 4.9 078/190] mmc: host: omap_hsmmc: checking for NULL instead of IS_ERR() Thread-Index: AQHTtpo7h15Rd7BIAkaaify54ym3lA== Date: Thu, 8 Mar 2018 04:59:26 +0000 Message-ID: <20180308045810.8041-78-alexander.levin@microsoft.com> References: <20180308045810.8041-1-alexander.levin@microsoft.com> In-Reply-To: <20180308045810.8041-1-alexander.levin@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [52.168.54.252] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;DM5PR2101MB0901;7:ynrr5K5WUtgcbRLWTM+ckKSr0eq94i5JVwaB6+9liwYP7pb92DKSROrl6ilWqMX9cAd3l+vc8qoOUOP3W2dm7jiWBZd0tvGAYgtsDbv3k/K1qD+NPVUoaRdOQv4zU/hi7y7PVuttrowX3zIOr1Q6D8EmFfdShgW2o/8bKq3U6S8GsybNb/bUbrzK5lXjZrS2w8b6gyfH0bjkOwYsFn1pmTI1rwxfbduAaEgmsWBhLxEmO7JjMsgw0ly96xVqZpCO;20:jWQjWP3lCnnz5t7pOhxq3Fj746FL36Iz1cyb1VM7ZL/GX/FD9v43Bl+L5FbwPSXLRaHYN6DJ7T9KMZ0uYdF9IvbuP89SNWRTZr/BtO0BCyAFWtyc/Aj1JPAA0buz6iFp7bclgf12wJR437XE4RdcSoklfnkJ4MIG3TlCNzwqM7Q= x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: fc58b7e1-a449-4b5a-068d-08d584b1a60b x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(7020095)(4652020)(48565401081)(5600026)(4604075)(3008032)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7193020);SRVR:DM5PR2101MB0901; x-ms-traffictypediagnostic: DM5PR2101MB0901: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alexander.Levin@microsoft.com; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(28532068793085)(31051911155226)(89211679590171)(146099531331640); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(8211001083)(61425038)(6040501)(2401047)(8121501046)(5005006)(3231220)(944501244)(52105095)(93006095)(93001095)(10201501046)(3002001)(6055026)(61426038)(61427038)(6041288)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011);SRVR:DM5PR2101MB0901;BCL:0;PCL:0;RULEID:;SRVR:DM5PR2101MB0901; x-forefront-prvs: 060503E79B x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(39860400002)(39380400002)(366004)(376002)(346002)(396003)(189003)(199004)(2501003)(5250100002)(99286004)(10290500003)(53936002)(14454004)(72206003)(76176011)(97736004)(6512007)(106356001)(86362001)(10090500001)(7736002)(6436002)(8936002)(6486002)(36756003)(110136005)(305945005)(54906003)(81166006)(105586002)(2900100001)(66066001)(6116002)(22452003)(3846002)(1076002)(478600001)(3660700001)(102836004)(81156014)(6506007)(107886003)(8676002)(25786009)(68736007)(4326008)(3280700002)(2906002)(86612001)(2950100002)(26005)(316002)(5660300001)(186003)(22906009)(217873001);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR2101MB0901;H:DM5PR2101MB1032.namprd21.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; x-microsoft-antispam-message-info: cAoKQdfVMdi6+fStINDq6JFOH8iKLmjXKIhfZuvtA9SeNFX25wqgIqTnztkzlKyhIrFfNTfc0mAK39ZM1xf7CjlUzvUaDJ2wGjPewRJ6q68WdyhnwszVJG7BKdv4rnl1XeboGCYNvJV/j0q48eFa6y0yHywlCUl8wNuFWM6kd35HvD+DDTsVu08jiULfj2tFgXrHWD0lvOEY3ABlLbrHjo1RA7GY+XqK6nf9AWbeWnm78c2OMUmotnY3Q2Dqd/L9tKNpSZfOaBhFJUB/7fsaAno+NGfdOLlkjjtbwe0f21446Aaylp3xiONTJzFSrOIajIwR2A+Jfgesmgwt6CojMg== spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: fc58b7e1-a449-4b5a-068d-08d584b1a60b X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Mar 2018 04:59:26.2905 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR2101MB0901 Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: From: Dan Carpenter [ Upstream commit ec5ab8933772c87f24ad62a4a602fe8949f423c2 ] devm_pinctrl_get() returns error pointers, it never returns NULL. Fixes: 455e5cd6f736 ("mmc: omap_hsmmc: Pin remux workaround to support SDIO= interrupt on AM335x") Signed-off-by: Dan Carpenter Reviewed-by: Kishon Vijay Abraham I Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin --- drivers/mmc/host/omap_hsmmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c index 5f2f24a7360d..a082aa330f47 100644 --- a/drivers/mmc/host/omap_hsmmc.c +++ b/drivers/mmc/host/omap_hsmmc.c @@ -1762,8 +1762,8 @@ static int omap_hsmmc_configure_wake_irq(struct omap_= hsmmc_host *host) */ if (host->pdata->controller_flags & OMAP_HSMMC_SWAKEUP_MISSING) { struct pinctrl *p =3D devm_pinctrl_get(host->dev); - if (!p) { - ret =3D -ENODEV; + if (IS_ERR(p)) { + ret =3D PTR_ERR(p); goto err_free_irq; } if (IS_ERR(pinctrl_lookup_state(p, PINCTRL_STATE_DEFAULT))) { --=20 2.14.1