From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935657AbeCHKdK (ORCPT ); Thu, 8 Mar 2018 05:33:10 -0500 Received: from mail-pl0-f66.google.com ([209.85.160.66]:40346 "EHLO mail-pl0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755334AbeCHKdI (ORCPT ); Thu, 8 Mar 2018 05:33:08 -0500 X-Google-Smtp-Source: AG47ELuH/8NYKilgWV3+OSY00PhRD8BgFvRTQiK0XRscwdGJssEv92ydYCM5hOnrDpWWHODWntrLvg== Date: Thu, 8 Mar 2018 16:03:05 +0530 From: Viresh Kumar To: Claudio Scordino Cc: Peter Zijlstra , "Rafael J . Wysocki" , Ingo Molnar , Patrick Bellasi , Dietmar Eggemann , Morten Rasmussen , Juri Lelli , Vincent Guittot , Todd Kjos , Joel Fernandes , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3] cpufreq: schedutil: rate limits for SCHED_DEADLINE Message-ID: <20180308103305.GK6842@vireshk-i7> References: <1520504950-8544-1-git-send-email-claudio@evidence.eu.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520504950-8544-1-git-send-email-claudio@evidence.eu.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08-03-18, 11:29, Claudio Scordino wrote: > When the SCHED_DEADLINE scheduling class increases the CPU utilization, > we should not wait for the rate limit, otherwise we may miss some > deadline. > > Tests using rt-app on Exynos5422 with up to 10 SCHED_DEADLINE tasks have > shown reductions of even 10% of deadline misses with a negligible > increase of energy consumption (measured through Baylibre Cape). > > Signed-off-by: Claudio Scordino > CC: Ingo Molnar > CC: Patrick Bellasi > CC: Dietmar Eggemann > CC: Morten Rasmussen > CC: Juri Lelli > CC: Viresh Kumar > CC: Vincent Guittot > CC: Todd Kjos > CC: Joel Fernandes > CC: linux-pm@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > Changes from v2: > - Rate limit ignored also in case of "fast switch" > - Specific routine added > --- > Changes from v1: > - Logic moved from sugov_should_update_freq() to > sugov_update_single()/_shared() to not duplicate data structures > - Rate limit not ignored in case of "fast switch" > --- > kernel/sched/cpufreq_schedutil.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c > index 7936f54..13f9cce 100644 > --- a/kernel/sched/cpufreq_schedutil.c > +++ b/kernel/sched/cpufreq_schedutil.c > @@ -260,6 +260,17 @@ static bool sugov_cpu_is_busy(struct sugov_cpu *sg_cpu) > static inline bool sugov_cpu_is_busy(struct sugov_cpu *sg_cpu) { return false; } > #endif /* CONFIG_NO_HZ_COMMON */ > > +/* > + * Make sugov_should_update_freq() ignore the rate limit when DL > + * has increased the utilization. > + */ > +static inline > +void set_dl_rate_limit(struct sugov_cpu *sg_cpu, struct sugov_policy *sg_policy) Maybe it could be renamed as ignore_dl_rate_limit() ? Lets see what others have to say. But looks fine otherwise. Acked-by: Viresh Kumar -- viresh