From: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
To: Colin King <colin.king@canonical.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
alsa-devel@alsa-project.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: TSCS42xx: make const array norm_addrs static, reduces object code size
Date: Thu, 8 Mar 2018 19:03:09 -0600 [thread overview]
Message-ID: <20180309010308.GA19046@t7-ThinkPad-E560> (raw)
In-Reply-To: <20180214172153.5749-1-colin.king@canonical.com>
On Wed, Feb 14, 2018 at 05:21:53PM +0000, Colin King wrote:
> Don't populate the const array norm_addrs on the stack, instead make it
> static. Makes the object code smaller by over 230 bytes. Also re-format
> array data as the insertion of the static keywork made the first line
> overly long.
I have tested this on our HAT and it works well. You can add:
Reviewed-by: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
Tested-by: Steven Eckhoff <steven.eckhoff.opensource@gmail.com>
Regards,
Steven
prev parent reply other threads:[~2018-03-09 1:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 17:21 Colin King
2018-02-15 15:34 ` Applied "ASoC: TSCS42xx: make const array norm_addrs static, reduces object code size" to the asoc tree Mark Brown
2018-03-09 1:03 ` Steven Eckhoff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309010308.GA19046@t7-ThinkPad-E560 \
--to=steven.eckhoff.opensource@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®