From: Lee Jones <lee.jones@linaro.org>
To: Jeffy Chen <jeffy.chen@rock-chips.com>
Cc: linux-kernel@vger.kernel.org, broonie@kernel.org,
alexandre.belloni@bootlin.com, Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v4 1/4] mfd: syscon: Set name of regmap_config
Date: Fri, 9 Mar 2018 08:15:28 +0000 [thread overview]
Message-ID: <20180309081528.shgirroytqjtlx3d@dell> (raw)
In-Reply-To: <20180309015146.8297-2-jeffy.chen@rock-chips.com>
On Fri, 09 Mar 2018, Jeffy Chen wrote:
> We are now allowing to register debugfs without a valid device, and not
> having a valid name will end up using "dummy*" to create debugfs dir.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v4: None
> Changes in v3:
> Modify commit message.
>
> drivers/mfd/syscon.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index fc9ba0ea4e44..b6d05cd934e6 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -110,6 +110,7 @@ static struct syscon *of_syscon_register(struct device_node *np)
> syscon_config.reg_stride = reg_io_width;
> syscon_config.val_bits = reg_io_width * 8;
> syscon_config.max_register = resource_size(&res) - reg_io_width;
> + syscon_config.name = of_node_full_name(np);
It's difficult to review, since we cannot see what's happening with
the rest of the patch set. Would you mind re-sending the whole set to
all parties please?
--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2018-03-09 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 1:51 [PATCH v4 0/4] " Jeffy Chen
2018-03-09 1:51 ` [PATCH v4 1/4] mfd: syscon: " Jeffy Chen
2018-03-09 8:15 ` Lee Jones [this message]
2018-03-09 1:51 ` [PATCH v4 2/4] rtc: at91sam9: " Jeffy Chen
2018-03-09 1:51 ` [PATCH v4 3/4] clk: lpc32xx: " Jeffy Chen
2018-03-09 1:51 ` [PATCH v4 4/4] ARM: rockchip: " Jeffy Chen
2018-03-09 8:16 ` [PATCH v4 0/4] " Lee Jones
2018-03-09 8:45 ` JeffyChen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180309081528.shgirroytqjtlx3d@dell \
--to=lee.jones@linaro.org \
--cc=alexandre.belloni@bootlin.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®