From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751088AbeCILqB (ORCPT ); Fri, 9 Mar 2018 06:46:01 -0500 Received: from elvis.franken.de ([193.175.24.41]:46576 "EHLO elvis.franken.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750912AbeCILqA (ORCPT ); Fri, 9 Mar 2018 06:46:00 -0500 Date: Fri, 9 Mar 2018 11:52:49 +0100 From: Tom Bogendoerfer To: Finn Thain Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls Message-ID: <20180309105249.GA6536@alpha.franken.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Mar 07, 2018 at 05:56:41PM +1100, Finn Thain wrote: > In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev > in dma api calls as if it was a pointer to a struct device. But > it actually points to a struct platform_device. Fix this. > > Cc: Thomas Bogendoerfer > Signed-off-by: Finn Thain Looks good. Reviewed-by: Thomas Bogendoerfer Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]