mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Engestrom <eric.engestrom@imgtec.com>
To: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: Emil Velikov <emil.l.velikov@gmail.com>,
	Florian Tobias Schandinat <FlorianSchandinat@gmx.de>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	<linux-fbdev@vger.kernel.org>, Kees Cook <keescook@chromium.org>,
	<kernel-hardening@lists.openwall.com>,
	<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	"Gustavo A. R. Silva" <garsilva@embeddedor.com>
Subject: Re: [PATCH] video: fbdev: via: remove VLA usage
Date: Fri, 9 Mar 2018 10:59:40 +0000	[thread overview]
Message-ID: <20180309105940.22hd2uy2mv7wahzb@imgtec.com> (raw)
In-Reply-To: <20180308173949.GA19305@embeddedgus>

On Thursday, 2018-03-08 11:39:49 -0600, Gustavo A. R. Silva wrote:
> In preparation to enabling -Wvla, remove VLA usage.
> 
> Also, fixed as part of the directive to remove all VLAs from
> the kernel: https://lkml.org/lkml/2018/3/7/621
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

Sorry for my reply on v1, I missed that Emil already replied to another
post of the same patch (side note on that, making use of `-vX` and
`--in-reply-to` helps track the evolution of patches)

This looks good to me:
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>

> ---
>  drivers/video/fbdev/via/via_aux_sii164.c | 2 +-
>  drivers/video/fbdev/via/via_aux_vt1631.c | 2 +-
>  drivers/video/fbdev/via/via_aux_vt1632.c | 2 +-
>  drivers/video/fbdev/via/via_aux_vt1636.c | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/via/via_aux_sii164.c b/drivers/video/fbdev/via/via_aux_sii164.c
> index ca1b35f..c27f62c 100644
> --- a/drivers/video/fbdev/via/via_aux_sii164.c
> +++ b/drivers/video/fbdev/via/via_aux_sii164.c
> @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr)
>  		.name	=	name};
>  	/* check vendor id and device id */
>  	const u8 id[] = {0x01, 0x00, 0x06, 0x00}, len = ARRAY_SIZE(id);
> -	u8 tmp[len];
> +	u8 tmp[ARRAY_SIZE(id)];
>  
>  	if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len))
>  		return;
> diff --git a/drivers/video/fbdev/via/via_aux_vt1631.c b/drivers/video/fbdev/via/via_aux_vt1631.c
> index 06e742f..32978a0 100644
> --- a/drivers/video/fbdev/via/via_aux_vt1631.c
> +++ b/drivers/video/fbdev/via/via_aux_vt1631.c
> @@ -36,7 +36,7 @@ void via_aux_vt1631_probe(struct via_aux_bus *bus)
>  		.name	=	name};
>  	/* check vendor id and device id */
>  	const u8 id[] = {0x06, 0x11, 0x91, 0x31}, len = ARRAY_SIZE(id);
> -	u8 tmp[len];
> +	u8 tmp[ARRAY_SIZE(id)];
>  
>  	if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len))
>  		return;
> diff --git a/drivers/video/fbdev/via/via_aux_vt1632.c b/drivers/video/fbdev/via/via_aux_vt1632.c
> index d24f4cd..cec8cc4 100644
> --- a/drivers/video/fbdev/via/via_aux_vt1632.c
> +++ b/drivers/video/fbdev/via/via_aux_vt1632.c
> @@ -36,7 +36,7 @@ static void probe(struct via_aux_bus *bus, u8 addr)
>  		.name	=	name};
>  	/* check vendor id and device id */
>  	const u8 id[] = {0x06, 0x11, 0x92, 0x31}, len = ARRAY_SIZE(id);
> -	u8 tmp[len];
> +	u8 tmp[ARRAY_SIZE(id)];
>  
>  	if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len))
>  		return;
> diff --git a/drivers/video/fbdev/via/via_aux_vt1636.c b/drivers/video/fbdev/via/via_aux_vt1636.c
> index 9e015c1..2b10bc2 100644
> --- a/drivers/video/fbdev/via/via_aux_vt1636.c
> +++ b/drivers/video/fbdev/via/via_aux_vt1636.c
> @@ -36,7 +36,7 @@ void via_aux_vt1636_probe(struct via_aux_bus *bus)
>  		.name	=	name};
>  	/* check vendor id and device id */
>  	const u8 id[] = {0x06, 0x11, 0x45, 0x33}, len = ARRAY_SIZE(id);
> -	u8 tmp[len];
> +	u8 tmp[ARRAY_SIZE(id)];
>  
>  	if (!via_aux_read(&drv, 0x00, tmp, len) || memcmp(id, tmp, len))
>  		return;
> -- 
> 2.7.4
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2018-03-09 10:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-08 17:39 Gustavo A. R. Silva
2018-03-09 10:59 ` Eric Engestrom [this message]
2018-03-09 11:02   ` Emil Velikov
2018-03-12 16:04     ` Bartlomiej Zolnierkiewicz
2018-03-13  3:29     ` Gustavo A. R. Silva

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180309105940.22hd2uy2mv7wahzb@imgtec.com \
    --to=eric.engestrom@imgtec.com \
    --cc=FlorianSchandinat@gmx.de \
    --cc=b.zolnierkie@samsung.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=emil.l.velikov@gmail.com \
    --cc=garsilva@embeddedor.com \
    --cc=gustavo@embeddedor.com \
    --cc=keescook@chromium.org \
    --cc=kernel-hardening@lists.openwall.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®