From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932227AbeCIPEd (ORCPT ); Fri, 9 Mar 2018 10:04:33 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:60448 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932200AbeCIPEb (ORCPT ); Fri, 9 Mar 2018 10:04:31 -0500 Date: Fri, 9 Mar 2018 23:04:11 +0800 From: Herbert Xu To: Joe Perches Cc: =?iso-8859-1?Q?Hern=E1n?= Gonzalez , davem@davemloft.net, steven.lin1@broadcom.com, arvind.yadav.cs@gmail.com, colin.king@canonical.com, raveendra.padasalagi@broadcom.com, ray.jui@broadcom.com, scott.branden@broadcom.com, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] crypto: bcm: Constify *hash_alg_name[] Message-ID: <20180309150411.GA13375@gondor.apana.org.au> References: <1519768888-19866-1-git-send-email-hernan@vanguardiasur.com.ar> <1519768888-19866-3-git-send-email-hernan@vanguardiasur.com.ar> <20180309142954.GA12852@gondor.apana.org.au> <1520606135.26370.9.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1520606135.26370.9.camel@perches.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 09, 2018 at 06:35:35AM -0800, Joe Perches wrote: > > and likely, as this is a global name, it should > be something like crypto_hash_alg_name crypto_ is not a good prefix here. Perhaps crypto_bcm_. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt