Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver

From: Andrew Lunn <andrew@lunn.ch>
To: Razvan Stefanescu <razvan.stefanescu@nxp.com>
Cc: devel@driverdev.osuosl.org, arnd@arndb.de,
	gregkh@linuxfoundation.org, ioana.ciornei@nxp.com,
	alexandru.marginean@nxp.com, agraf@suse.de,
	linux-kernel@vger.kernel.org, stuyoder@gmail.com,
	netdev@vger.kernel.org, laurentiu.tudor@nxp.com
Subject: Re: [PATCH v4 2/6] staging: fsl-dpaa2/ethsw: Add Freescale DPAA2 Ethernet Switch driver
Date: Mon, 12 Mar 2018 15:36:54 +0100	[thread overview]
Message-ID: <20180312143654.GB21068@lunn.ch> (raw)
In-Reply-To: <20180312084955.12686-3-razvan.stefanescu@nxp.com>

> +static int port_netdevice_event(struct notifier_block *unused,
> +				unsigned long event, void *ptr)
> +{
> +	struct net_device *netdev = netdev_notifier_info_to_dev(ptr);
> +	struct netdev_notifier_changeupper_info *info = ptr;
> +	struct net_device *upper_dev;
> +	int err = 0;
> +
> +	if (netdev->netdev_ops != &ethsw_port_ops)
> +		return NOTIFY_DONE;
> +
> +	/* Handle just upper dev link/unlink for the moment */
> +	if (event == NETDEV_CHANGEUPPER) {
> +		upper_dev = info->upper_dev;
> +		if (netif_is_bridge_master(upper_dev)) {
> +			if (info->linking)
> +				err = port_bridge_join(netdev);
> +			else
> +				err = port_bridge_leave(netdev);
> +		}
> +	}
> +
> +	return notifier_from_errno(err);
> +}

I could be missing something here, but don't you need to pass to
port_bridge_join() which bridge the port is joining. There can be
multiple bridges, so you need to ensure the port joins the correct
bridge.

	Andrew
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel