From: Mark Brown <broonie@kernel.org>
To: Charles Keepax <ckeepax@opensource.cirrus.com>
Cc: Kees Cook <keescook@chromium.org>,
moderated for non-subscribers <alsa-devel@alsa-project.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>
Subject: Re: [alsa-devel] [PATCH] ASoC: soc-core: Add missing NULL check
Date: Mon, 12 Mar 2018 09:02:04 -0700 [thread overview]
Message-ID: <20180312160204.GA2186@sirena.org.uk> (raw)
In-Reply-To: <20180312103143.y7bidz4gj6ya7dgo@localhost.localdomain>
[-- Attachment #1: Type: text/plain, Size: 784 bytes --]
On Mon, Mar 12, 2018 at 10:31:43AM +0000, Charles Keepax wrote:
> On Fri, Mar 09, 2018 at 08:22:42PM +0000, Mark Brown wrote:
> > I think I might just remove the file though, it's been non-functional on
> > most systems for a while now as almost all the drivers migrated to
> > regmap and nobody complained so we should be safe. There's still
> > something that ought to be investigated here.
> Looks like we might already be about to try that since it looks
> like the componentisation actually removed these files, although
> I assume inadvertently.
No, that's an intended effect. This only exists for CODEC drivers and
even then it's only ones that use the legacy ASoC I/O code that really
ever got anything from this. Anything that's well maintained should be
using regmap.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-12 16:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-08 20:06 Kees Cook
2018-03-09 12:50 ` Mark Brown
2018-03-09 18:45 ` Kees Cook
2018-03-09 19:35 ` Pavel Machek
2018-03-09 20:22 ` Mark Brown
2018-03-12 10:31 ` [alsa-devel] " Charles Keepax
2018-03-12 16:02 ` Mark Brown [this message]
2018-03-09 20:19 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312160204.GA2186@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=keescook@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome