From: Mark Brown <broonie@kernel.org>
To: codekipper@gmail.com
Cc: maxime.ripard@free-electrons.com, wens@csie.org,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
be17068@iperbole.bo.it
Subject: Re: [PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback
Date: Mon, 12 Mar 2018 11:35:21 -0700 [thread overview]
Message-ID: <20180312183521.GP2186@sirena.org.uk> (raw)
In-Reply-To: <20180312155753.9478-7-codekipper@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 426 bytes --]
On Mon, Mar 12, 2018 at 04:57:53PM +0100, codekipper@gmail.com wrote:
> +- loopback: if this property is present then the dai is configured in
> + loopback mode where the output fifo is redirected to the input
> + fifo.
This really doesn't seem like something that ought to go into the DT
and hence ABI given that there's obviously no reason to use this in
production. Just make it be a #define in the code or something.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-03-12 18:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 15:57 [PATCH v2 0/6] ASoC: sun4i-i2s: Updates to the driver codekipper
2018-03-12 15:57 ` [PATCH v2 1/6] ASoC: sun4i-i2s: Add slot width override codekipper
2018-03-12 18:20 ` Mark Brown
2018-03-13 11:59 ` [linux-sunxi] " Julian Calaby
2018-03-12 15:57 ` [PATCH v2 2/6] ASoC: sun4i-i2s: Add regmap field to sign extend sample codekipper
2018-03-12 15:57 ` [PATCH v2 3/6] ASoC: sun4i-i2s: Correct divider calculations codekipper
2018-03-13 8:20 ` Maxime Ripard
2018-03-12 15:57 ` [PATCH v2 4/6] ASoC: sun4i-i2s: Add multi-lane functionality codekipper
2018-03-13 8:00 ` Maxime Ripard
2018-03-13 8:15 ` Code Kipper
2018-03-13 8:23 ` Maxime Ripard
2018-03-13 8:59 ` Code Kipper
2018-03-12 15:57 ` [PATCH v2 5/6] ASoc: sun4i-i2s: Add 20, 24 and 32 bit support codekipper
2018-03-12 15:57 ` [PATCH v2 6/6] ASoC: sun4i-i2s: Add support for loopback codekipper
2018-03-12 18:35 ` Mark Brown [this message]
2018-03-13 13:39 ` [linux-sunxi] " Chris Obbard
2018-03-13 14:03 ` Maxime Ripard
2018-03-13 16:26 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312183521.GP2186@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=be17068@iperbole.bo.it \
--cc=codekipper@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome