From: David Miller <davem@davemloft.net>
To: jelsasser@appneta.com
Cc: gregkh@linuxfoundation.org, edumazet@google.com,
willemb@google.com, glider@google.com, xiyou.wangcong@gmail.com,
vyasevich@gmail.com, mkubecek@suse.cz, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll
Date: Tue, 13 Mar 2018 10:51:15 -0400 (EDT) [thread overview]
Message-ID: <20180313.105115.682846171057663636.davem@davemloft.net> (raw)
In-Reply-To: <20180313053248.13654-2-jelsasser@appneta.com>
From: Josh Elsasser <jelsasser@appneta.com>
Date: Mon, 12 Mar 2018 22:32:00 -0700
> init_dummy_netdev() leaves its netdev_ops pointer zeroed. This leads
> to a NULL pointer dereference when sk_busy_loop fires against an iwlwifi
> wireless adapter and checks napi->dev->netdev_ops->ndo_busy_poll.
>
> Avoid this by ensuring napi->dev->netdev_ops is valid before following
> the pointer, avoiding the following panic when busy polling on a dummy
> netdev:
...
> Commit 79e7fff47b7b ("net: remove support for per driver ndo_busy_poll()")
> indirectly fixed this upstream in linux-4.11 by removing the offending
> pointer usage. No other users of napi->dev touch its netdev_ops.
>
> Fixes: 060212928670 ("net: add low latency socket poll")
> Fixes: ce6aea93f751 ("net: network drivers no longer need to implement ndo_busy_poll()") - 4.9.y
> Signed-off-by: Josh Elsasser <jelsasser@appneta.com>
Ok, queued up for -stable, thanks.
prev parent reply other threads:[~2018-03-13 14:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 5:31 [PATCH 0/1] net: avoid a kernel panic during sk_busy_loop Josh Elsasser
2018-03-13 5:32 ` [PATCH v2 1/1] net: check before dereferencing netdev_ops during busy poll Josh Elsasser
2018-03-13 5:50 ` Eric Dumazet
2018-03-13 14:51 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313.105115.682846171057663636.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=jelsasser@appneta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=vyasevich@gmail.com \
--cc=willemb@google.com \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®