From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbeCMNUH (ORCPT ); Tue, 13 Mar 2018 09:20:07 -0400 Received: from mga06.intel.com ([134.134.136.31]:2871 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752406AbeCMNUE (ORCPT ); Tue, 13 Mar 2018 09:20:04 -0400 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,464,1515484800"; d="scan'208";a="38400560" Date: Tue, 13 Mar 2018 08:20:00 -0500 From: Shiraz Saleem To: Arnd Bergmann Cc: Faisal Latif , Doug Ledford , Jason Gunthorpe , Artemy Kovalyov , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] 40iw: include linux/irq.h Message-ID: <20180313132000.GA18400@ssaleem-MOBL4.amr.corp.intel.com> References: <20180313120644.2619889-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180313120644.2619889-1-arnd@arndb.de> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 13, 2018 at 01:06:20PM +0100, Arnd Bergmann wrote: > We get a build failure on ARM unless the header is included explicitly: > > drivers/infiniband/hw/i40iw/i40iw_verbs.c: In function 'i40iw_get_vector_affinity': > drivers/infiniband/hw/i40iw/i40iw_verbs.c:2747:9: error: implicit declaration of function 'irq_get_affinity_mask'; did you mean 'irq_create_affinity_masks'? [-Werror=implicit-function-declaration] > return irq_get_affinity_mask(msix_vec->irq); > ^~~~~~~~~~~~~~~~~~~~~ > irq_create_affinity_masks > drivers/infiniband/hw/i40iw/i40iw_verbs.c:2747:9: error: returning 'int' from a function with return type 'const struct cpumask *' makes pointer from integer without a cast [-Werror=int-conversion] > return irq_get_affinity_mask(msix_vec->irq); > > Fixes: 7e952b19eb63 ("i40iw: Implement get_vector_affinity API") > Signed-off-by: Arnd Bergmann > --- Looks like you beat me to it. 0-day caught this on rdma-nxt and I was going to send the fix today. Typo in the subject. 40iw --> i40iw. Othwerwise, looks good. Thanks for the patch, Arnd! Shiraz