From: Michal Hocko <mhocko@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Gaurav Kohli <gkohli@codeaurora.org>,
Andrew Morton <akpm@linux-foundation.org>,
kirill.shutemov@linux.intel.com,
Andrea Arcangeli <aarcange@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [patch] mm, oom: remove 3% bonus for CAP_SYS_ADMIN processes
Date: Tue, 13 Mar 2018 14:39:46 +0100 [thread overview]
Message-ID: <20180313133946.GT12772@dhcp22.suse.cz> (raw)
In-Reply-To: <alpine.DEB.2.20.1803071548510.6996@chino.kir.corp.google.com>
On Wed 07-03-18 15:52:15, David Rientjes wrote:
> Since the 2.6 kernel, the oom killer has slightly biased away from
> CAP_SYS_ADMIN processes by discounting some of its memory usage in
> comparison to other processes.
>
> This has always been implicit and nothing exactly relies on the behavior.
>
> Gaurav notices that __task_cred() can dereference a potentially freed
> pointer if the task under consideration is exiting because a reference to
> the task_struct is not held.
>
> Remove the CAP_SYS_ADMIN bias so that all processes are treated equally.
>
> If any CAP_SYS_ADMIN process would like to be biased against, it is always
> allowed to adjust /proc/pid/oom_score_adj.
>
> Reported-by: Gaurav Kohli <gkohli@codeaurora.org>
> Signed-off-by: David Rientjes <rientjes@google.com>
This is simpler than playing reference counting tricks and whatnot.
Moreover I do agree that this heuristic is questionable on its own. The
bias is basically random and invisible to the userspace. We already have
a way to tune the same thing by oom_score_adj
Acked-by: Michal Hocko <mhocko@suse.com>
> ---
> mm/oom_kill.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/mm/oom_kill.c b/mm/oom_kill.c
> --- a/mm/oom_kill.c
> +++ b/mm/oom_kill.c
> @@ -224,13 +224,6 @@ unsigned long oom_badness(struct task_struct *p, struct mem_cgroup *memcg,
> mm_pgtables_bytes(p->mm) / PAGE_SIZE;
> task_unlock(p);
>
> - /*
> - * Root processes get 3% bonus, just like the __vm_enough_memory()
> - * implementation used by LSMs.
> - */
> - if (has_capability_noaudit(p, CAP_SYS_ADMIN))
> - points -= (points * 3) / 100;
> -
> /* Normalize to oom_score_adj units */
> adj *= totalpages / 1000;
> points += adj;
--
Michal Hocko
SUSE Labs
prev parent reply other threads:[~2018-03-13 13:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-07 23:52 David Rientjes
2018-03-13 13:39 ` Michal Hocko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180313133946.GT12772@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=gkohli@codeaurora.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®