From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933590AbeCMQiz (ORCPT ); Tue, 13 Mar 2018 12:38:55 -0400 Received: from mail-wr0-f193.google.com ([209.85.128.193]:35369 "EHLO mail-wr0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933538AbeCMQiv (ORCPT ); Tue, 13 Mar 2018 12:38:51 -0400 X-Google-Smtp-Source: AG47ELtSrgTwE8pfCMmj36R9k8AmsOp7I/w/XJTHtHzo2Re4iqDcjJO0RMHBu9mkHvq5qVpEt2bVRQ== Date: Tue, 13 Mar 2018 17:38:44 +0100 From: Daniel Scheller To: Arnd Bergmann , Mauro Carvalho Chehab Cc: Binoy Jayan , Jasmin Jessich , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: ngene: avoid unused variable warning Message-ID: <20180313173844.0644a716@perian.wuest.de> In-Reply-To: <20180313130620.4040088-1-arnd@arndb.de> References: <20180313130620.4040088-1-arnd@arndb.de> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am Tue, 13 Mar 2018 14:06:03 +0100 schrieb Arnd Bergmann : > The newly added pdev variable is only used in an #ifdef, causing a > build warning without CONFIG_PCI_MSI, unless we move the declaration > inside the same #ifdef: > > drivers/media/pci/ngene/ngene-core.c: In function 'ngene_start': > drivers/media/pci/ngene/ngene-core.c:1328:17: error: unused variable 'pdev' [-Werror=unused-variable] > > Fixes: 6795bf626482 ("media: ngene: convert kernellog printing from printk() to dev_*() macros") > Signed-off-by: Arnd Bergmann Acked-by: Daniel Scheller Thanks! > --- > drivers/media/pci/ngene/ngene-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/pci/ngene/ngene-core.c b/drivers/media/pci/ngene/ngene-core.c > index 3b9a1bfaf6c0..25f16833a475 100644 > --- a/drivers/media/pci/ngene/ngene-core.c > +++ b/drivers/media/pci/ngene/ngene-core.c > @@ -1325,7 +1325,6 @@ static int ngene_buffer_config(struct ngene *dev) > > static int ngene_start(struct ngene *dev) > { > - struct device *pdev = &dev->pci_dev->dev; > int stat; > int i; > > @@ -1359,6 +1358,7 @@ static int ngene_start(struct ngene *dev) > #ifdef CONFIG_PCI_MSI > /* enable MSI if kernel and card support it */ > if (pci_msi_enabled() && dev->card_info->msi_supported) { > + struct device *pdev = &dev->pci_dev->dev; > unsigned long flags; > > ngwritel(0, NGENE_INT_ENABLE); Best regards, Daniel Scheller -- https://github.com/herrnst