mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Michal Hocko <mhocko@kernel.org>
Cc: linux-kernel@vger.kernel.org, rdunlap@infradead.org,
	sfr@canb.auug.org.au
Subject: Re: + headers-untangle-kmemleakh-from-mmh-fix.patch added to -mm tree
Date: Wed, 14 Mar 2018 07:50:55 -0700	[thread overview]
Message-ID: <20180314075055.353f2d975defb2af34f65d2b@linux-foundation.org> (raw)
In-Reply-To: <20180314121704.GA23036@dhcp22.suse.cz>

On Wed, 14 Mar 2018 13:17:04 +0100 Michal Hocko <mhocko@kernel.org> wrote:

> > --- a/security/keys/big_key.c~headers-untangle-kmemleakh-from-mmh-fix
> > +++ a/security/keys/big_key.c
> > @@ -18,6 +18,7 @@
> >  #include <linux/err.h>
> >  #include <linux/scatterlist.h>
> >  #include <linux/random.h>
> > +#include <linux/vmalloc.h>
> >  #include <keys/user-type.h>
> >  #include <keys/big_key-type.h>
> >  #include <crypto/aead.h>
> 
> My build test battery says we need also this one, m32r complains
> otherwise for allmodconfig.
> 
> >From 5c3f7a041df707417532dd64b1d71fc29b24c0fe Mon Sep 17 00:00:00 2001
> From: Michal Hocko <mhocko@suse.com>
> Date: Wed, 14 Mar 2018 13:15:49 +0100
> Subject: [PATCH] headers-untangle-kmemleakh-from-mmh-fix-fix
> 
> m32r allmodconfig complains with
> security/integrity/digsig.c:146:2: error: implicit declaration of function 'vfree' [-Werror=implicit-function-declaration]
>   vfree(data);
>   ^
> Signed-off-by: Michal Hocko <mhocko@suse.com>
> ---
>  security/integrity/digsig.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/security/integrity/digsig.c b/security/integrity/digsig.c
> index 6f9e4ce568cd..9bb0a7f2863e 100644
> --- a/security/integrity/digsig.c
> +++ b/security/integrity/digsig.c
> @@ -18,6 +18,7 @@
>  #include <linux/cred.h>
>  #include <linux/key-type.h>
>  #include <linux/digsig.h>
> +#include <linux/vmalloc.h>
>  #include <crypto/public_key.h>
>  #include <keys/system_keyring.h>

hm, current linux-next.patch already has this change.  What happened here?

  reply	other threads:[~2018-03-14 14:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20180306234907.8-AwjmNNh%akpm@linux-foundation.org>
2018-03-14 12:17 ` Michal Hocko
2018-03-14 14:50   ` Andrew Morton [this message]
2018-03-14 14:57     ` Michal Hocko
2018-03-14 15:03       ` Andrew Morton
2018-03-14 15:06         ` Michal Hocko
2018-03-14 21:00   ` Stephen Rothwell
2018-03-15  7:43     ` Michal Hocko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180314075055.353f2d975defb2af34f65d2b@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®