From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753354AbeCNIfY (ORCPT ); Wed, 14 Mar 2018 04:35:24 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:39814 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753098AbeCNIfV (ORCPT ); Wed, 14 Mar 2018 04:35:21 -0400 Date: Wed, 14 Mar 2018 01:35:19 -0700 From: Christoph Hellwig To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, Mikael Starvik , Jesper Nilsson , Tony Luck , Fenghua Yu , David Howells , "Rafael J. Wysocki" , linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org, linux-am33-list@redhat.com Subject: Re: [PATCH] PCI/MSI: Don't set up INTx if MSI or MSI-X is enabled Message-ID: <20180314083519.GA24043@infradead.org> References: <152097754955.241946.9551793957889760940.stgit@bhelgaas-glaptop.roam.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <152097754955.241946.9551793957889760940.stgit@bhelgaas-glaptop.roam.corp.google.com> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Should this logic go into a little helper so that everyone is kept in sync?