From: Madalin Bucur <madalin.bucur@nxp.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
camelia.groza@nxp.com, leoyang.li@nxp.com,
linuxppc-dev@lists.ozlabs.org,
linux-arm-kernel@lists.infradead.org,
Madalin Bucur <madalin.bucur@nxp.com>
Subject: [PATCH 2/5] dpaa_eth: fix error in dpaa_remove()
Date: Wed, 14 Mar 2018 08:37:29 -0500 [thread overview]
Message-ID: <20180314133732.24068-3-madalin.bucur@nxp.com> (raw)
In-Reply-To: <20180314133732.24068-1-madalin.bucur@nxp.com>
The recent changes that make the driver probing compatible with DSA
were not propagated in the dpa_remove() function, breaking the
module unload function. Using the proper device to address the issue.
Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index 159dc2d..128e0a4 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -2871,7 +2871,7 @@ static int dpaa_remove(struct platform_device *pdev)
struct device *dev;
int err;
- dev = &pdev->dev;
+ dev = pdev->dev.parent;
net_dev = dev_get_drvdata(dev);
priv = netdev_priv(net_dev);
--
2.1.0
next prev parent reply other threads:[~2018-03-14 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 13:37 [PATCH 0/5] DPAA Ethernet fixes Madalin Bucur
2018-03-14 13:37 ` [PATCH 1/5] soc/fsl/qbman: fix issue in qman_delete_cgr_safe() Madalin Bucur
2018-03-14 13:37 ` Madalin Bucur [this message]
2018-03-14 13:37 ` [PATCH 3/5] dpaa_eth: remove duplicate initialization Madalin Bucur
2018-03-14 13:37 ` [PATCH 4/5] dpaa_eth: increment the RX dropped counter when needed Madalin Bucur
2018-03-14 13:37 ` [PATCH 5/5] dpaa_eth: remove duplicate increment of the tx_errors counter Madalin Bucur
2018-03-14 17:17 ` [PATCH 0/5] DPAA Ethernet fixes David Miller
2018-03-14 18:43 ` Joakim Tjernlund
2018-03-15 9:32 ` Madalin-cristian Bucur
2018-03-15 15:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314133732.24068-3-madalin.bucur@nxp.com \
--to=madalin.bucur@nxp.com \
--cc=camelia.groza@nxp.com \
--cc=davem@davemloft.net \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®