From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: tip-bot for Andy Whitcroft <tipbot@zytor.com>,
linux-tip-commits@vger.kernel.org, hpa@zytor.com,
dave.hansen@linux.intel.com, arjan@linux.intel.com,
dwmw@amazon.co.uk, gregkh@linuxfoundation.org,
torvalds@linux-foundation.org, apw@canonical.com, bp@alien8.de,
luto@kernel.org, dan.j.williams@intel.com, tglx@linutronix.de,
linux-kernel@vger.kernel.org, dwmw2@infradead.org,
peterz@infradead.org
Subject: Re: [tip:x86/pti] x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels
Date: Wed, 14 Mar 2018 08:51:46 -0500 [thread overview]
Message-ID: <20180314135146.o5pb434qwftkhui5@treble> (raw)
In-Reply-To: <20180314133943.t5dorqzvlieotljx@gmail.com>
On Wed, Mar 14, 2018 at 02:39:43PM +0100, Ingo Molnar wrote:
>
> * Josh Poimboeuf <jpoimboe@redhat.com> wrote:
>
> > On Wed, Mar 14, 2018 at 05:28:01AM -0700, tip-bot for Andy Whitcroft wrote:
> > > Commit-ID: a14bff131108faf50cc0cf864589fd71ee216c96
> > > Gitweb: https://git.kernel.org/tip/a14bff131108faf50cc0cf864589fd71ee216c96
> > > Author: Andy Whitcroft <apw@canonical.com>
> > > AuthorDate: Wed, 14 Mar 2018 11:24:27 +0000
> > > Committer: Ingo Molnar <mingo@kernel.org>
> > > CommitDate: Wed, 14 Mar 2018 13:24:31 +0100
> > >
> > > x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels
> > >
> > > In the following commit:
> > >
> > > 9e0e3c5130e9 ("x86/speculation, objtool: Annotate indirect calls/jumps for objtool")
> > >
> > > ... we added annotations for CALL_NOSPEC/JMP_NOSPEC on 64-bit x86 kernels,
> > > but we did not annotate the 32-bit path.
> > >
> > > Annotate it similarly.
> >
> > This patch has no effect because objtool only supports 64-bit kernels.
>
> Yeah, indeed - but it's still a good change for completeness, right?
Yeah, it's fine. Objtool won't use it, but I suppose it makes the code
less surprising and more consistent for humans.
--
Josh
prev parent reply other threads:[~2018-03-14 13:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 11:24 [PATCH 1/1] x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32bit Andy Whitcroft
2018-03-14 11:51 ` Peter Zijlstra
2018-03-14 12:24 ` Ingo Molnar
2018-03-14 12:28 ` [tip:x86/pti] x86/speculation, objtool: Annotate indirect calls/jumps for objtool on 32-bit kernels tip-bot for Andy Whitcroft
2018-03-14 13:03 ` Josh Poimboeuf
2018-03-14 13:39 ` Ingo Molnar
2018-03-14 13:51 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314135146.o5pb434qwftkhui5@treble \
--to=jpoimboe@redhat.com \
--cc=apw@canonical.com \
--cc=arjan@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=dave.hansen@linux.intel.com \
--cc=dwmw2@infradead.org \
--cc=dwmw@amazon.co.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=tipbot@zytor.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®