From: Michal Hocko <mhocko@kernel.org>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Will Deacon <will.deacon@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Marc Zyngier <marc.zyngier@arm.com>,
Daniel Vacek <neelx@redhat.com>,
Mel Gorman <mgorman@techsingularity.net>,
Paul Burton <paul.burton@imgtec.com>,
Pavel Tatashin <pasha.tatashin@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment"
Date: Wed, 14 Mar 2018 15:54:50 +0100 [thread overview]
Message-ID: <20180314145450.GI23100@dhcp22.suse.cz> (raw)
In-Reply-To: <CAKv+Gu9hrZnX6pmiCaT=S30KQ11tY4kv=qvdSPPZ2nYDC7P7eQ@mail.gmail.com>
On Wed 14-03-18 14:35:12, Ard Biesheuvel wrote:
> On 14 March 2018 at 14:13, Michal Hocko <mhocko@kernel.org> wrote:
> > Does http://lkml.kernel.org/r/20180313224240.25295-1-neelx@redhat.com
> > fix your issue? From the debugging info you provided it should because
> > the patch prevents jumping backwards.
> >
>
> The patch does fix the boot hang.
>
> But I am concerned that we are papering over a fundamental flaw in
> memblock_next_valid_pfn().
It seems that memblock_next_valid_pfn is doing the right thing here. It
is the alignment which moves the pfn back AFAICS. I am not really
impressed about the original patch either, to be completely honest.
It just looks awfully tricky. I still didn't manage to wrap my head
around the original issue though so I do not have much better ideas to
be honest.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-03-14 14:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-14 13:44 Ard Biesheuvel
2018-03-14 14:13 ` Michal Hocko
2018-03-14 14:35 ` Ard Biesheuvel
2018-03-14 14:54 ` Michal Hocko [this message]
2018-03-14 15:54 ` Ard Biesheuvel
2018-03-14 16:41 ` Ard Biesheuvel
2018-03-14 17:36 ` Ard Biesheuvel
2018-03-15 2:32 ` Daniel Vacek
2018-03-15 6:39 ` Ard Biesheuvel
2018-03-15 7:42 ` Daniel Vacek
2018-03-15 7:59 ` Ard Biesheuvel
2018-03-15 10:14 ` Michal Hocko
2018-03-15 10:17 ` Ard Biesheuvel
2018-03-15 11:43 ` Michal Hocko
2018-03-15 13:48 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180314145450.GI23100@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ard.biesheuvel@linaro.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=mgorman@techsingularity.net \
--cc=neelx@redhat.com \
--cc=pasha.tatashin@oracle.com \
--cc=paul.burton@imgtec.com \
--cc=torvalds@linux-foundation.org \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®