From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>, linux-kernel@vger.kernel.org
Cc: Dan Williams <dan.j.williams@intel.com>,
David Howells <dhowells@redhat.com>,
Daniel Vetter <daniel.vetter@intel.com>,
David Airlie <airlied@linux.ie>,
Stanimir Varbanov <stanimir.varbanov@linaro.org>,
Chris Mason <clm@fb.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
Joel Becker <jlbec@evilplan.org>, James Hogan <jhogan@kernel.org>,
Ralf Baechle <ralf@linux-mips.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
George Spelvin <linux@sciencehorizons.net>,
"Peter Zijlstra (Intel)" <peterz@infradead.org>
Subject: [PATCH 00/11] sched/wait: Replace wait_on_atomic_t() with wait_var_event()
Date: Thu, 15 Mar 2018 13:19:02 +0100 [thread overview]
Message-ID: <20180315121902.942902000@infradead.org> (raw)
I never really liked the whole wait_on_atomic_t() because of the hard-coded
type and condition. And when Dan proposed to add 50+ lines of duplication to
implement wait_on_atomic_one() I figured that was it.
Instead implement wait_var_event(), which at the fundamental level is much the
same hashed-waitqueue as wait_on_atomic_t() is, but it doesn't care about the
type or condition.
It is further modelled on the existing wait_event() API and is otherwise
consistent with that.
The existing:
wait_for_atomic_t(&my_atomic, wait_atomic_t, TASK_UNINTERRUPTIBLE);
wake_up_atomic_t(&my_atomic);
can be replaced with:
wait_var_event(&my_atomic, !atomic_read(&my_atomic));
wake_up_var(&my_atomic);
And Dan can do what he needs done using:
wait_var_event(&my_atomic, atomic_read(&my_atomic) == 1);
---
arch/mips/kernel/process.c | 2 +
arch/mips/kernel/traps.c | 4 +-
drivers/gpu/drm/drm_dp_aux_dev.c | 13 +--
drivers/gpu/drm/i915/selftests/intel_breadcrumbs.c | 14 +--
drivers/media/platform/qcom/venus/hfi.c | 8 +-
fs/afs/cell.c | 6 +-
fs/afs/rxrpc.c | 6 +-
fs/afs/server.c | 6 +-
fs/btrfs/extent-tree.c | 14 ++-
fs/btrfs/ioctl.c | 2 +-
fs/fscache/cookie.c | 7 +-
fs/nfs/inode.c | 5 -
fs/nfs/pagelist.c | 6 +-
fs/nfs/pnfs_nfs.c | 2 +-
fs/nfs/write.c | 6 +-
fs/ocfs2/filecheck.c | 9 +-
include/linux/fscache-cache.h | 2 +-
include/linux/wait_bit.h | 95 +++++++++++++-----
kernel/sched/wait_bit.c | 110 +++++----------------
19 files changed, 147 insertions(+), 170 deletions(-)
next reply other threads:[~2018-03-15 12:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 12:19 Peter Zijlstra [this message]
2018-03-15 12:19 ` [PATCH 01/11] sched/wait: Introduce wait_var_event() Peter Zijlstra
2018-03-19 16:45 ` Dan Williams
2018-03-15 12:19 ` [PATCH 02/11] sched/wait,drm: Replace wait_on_atomic_t usage Peter Zijlstra
2018-03-15 12:50 ` Chris Wilson
2018-03-15 12:19 ` [PATCH 03/11] sched/wait,media: " Peter Zijlstra
2018-03-15 12:19 ` [PATCH 04/11] sched/wait,afs: " Peter Zijlstra
2018-03-15 12:19 ` [PATCH 05/11] sched/wait,btrfs: " Peter Zijlstra
2018-03-15 20:17 ` David Sterba
2018-03-15 12:19 ` [PATCH 06/11] sched/wait,fscache: " Peter Zijlstra
2018-03-15 12:19 ` [PATCH 07/11] sched/wait,nfs: " Peter Zijlstra
2018-03-15 12:19 ` [PATCH 08/11] sched/wait,ocfs2: " Peter Zijlstra
2018-03-15 12:19 ` [PATCH 09/11] sched/wait,mips: Fix and replace " Peter Zijlstra
2018-03-15 12:19 ` [PATCH 10/11] sched/wait: Remove wait_on_atomic_t() Peter Zijlstra
2018-03-15 12:19 ` [PATCH 11/11] sched/wait: Improve __var_waitqueue() Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315121902.942902000@infradead.org \
--to=peterz@infradead.org \
--cc=airlied@linux.ie \
--cc=anna.schumaker@netapp.com \
--cc=clm@fb.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dhowells@redhat.com \
--cc=jhogan@kernel.org \
--cc=jlbec@evilplan.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@sciencehorizons.net \
--cc=mingo@kernel.org \
--cc=ralf@linux-mips.org \
--cc=stanimir.varbanov@linaro.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®