From: "Mylène Josserand" <mylene.josserand@bootlin.com>
To: lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
mark.rutland@arm.com, perex@perex.cz, tiwai@suse.com
Cc: alsa-devel@alsa-project.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alexandre.belloni@bootlin.com,
thomas.petazzoni@bootlin.com, mylene.josserand@bootlin.com,
michael@amarulasolutions.com
Subject: [PATCH v3 0/2] ASoC: Add support for DAC PCM1789
Date: Thu, 15 Mar 2018 17:18:23 +0100 [thread overview]
Message-ID: <20180315161825.5524-1-mylene.josserand@bootlin.com> (raw)
Hello everyone,
The current series is the 3rd version to add the support of Texas
Instrument's DAC PCM1789. This DAC is very minimalist and does
not have many registers.
It is important to notice that this DAC needs to always have clocks
enabled (even without any data) otherwise it will be in a "desynchronized"
state and can not send data correctly.
This issue has been solved by performing a reset each time a sound
is played. This reset can produce a "pop" noise.
Depending on your DAI, you will need to provide and enable the MCLK
to be able to communicate with this codec throught i2c.
Changes since v2:
- Update SPDX headers according to Mark Brown's review.
- Update the dt bindings according to Rob Herring's review.
Changes since v1:
- Create a new file to support pcm1789 instead of converting the
existing pcm179x driver. All the patches are merged into one patch.
- Update the code to use gpiod for the reset.
- Add some fixes according to Thomas Petazzoni's reviews
- Create a new patch to add device-tree bindings for this new DAC.
Thank you in advance for any review.
Best regards,
Mylène
Mylène Josserand (2):
ASoC: codecs: Add support for PCM1789
ASoC: Add bindings for PCM1789
.../devicetree/bindings/sound/pcm1789.txt | 22 ++
sound/soc/codecs/Kconfig | 12 +
sound/soc/codecs/Makefile | 4 +
sound/soc/codecs/pcm1789-i2c.c | 62 +++++
sound/soc/codecs/pcm1789.c | 274 +++++++++++++++++++++
sound/soc/codecs/pcm1789.h | 17 ++
6 files changed, 391 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/pcm1789.txt
create mode 100644 sound/soc/codecs/pcm1789-i2c.c
create mode 100644 sound/soc/codecs/pcm1789.c
create mode 100644 sound/soc/codecs/pcm1789.h
--
2.11.0
next reply other threads:[~2018-03-15 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 16:18 Mylène Josserand [this message]
2018-03-15 16:18 ` [PATCH v3 1/2] ASoC: codecs: Add support for PCM1789 Mylène Josserand
2018-03-17 11:19 ` kbuild test robot
2018-03-19 1:23 ` Mark Brown
2018-03-15 16:18 ` [PATCH v3 2/2] ASoC: Add bindings " Mylène Josserand
2018-03-18 12:52 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315161825.5524-1-mylene.josserand@bootlin.com \
--to=mylene.josserand@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®