From: Greg KH <gregkh@linuxfoundation.org>
To: richard.gong@linux.intel.com
Cc: catalin.marinas@arm.com, will.deacon@arm.com,
dinguyen@kernel.org, robh+dt@kernel.org, mark.rutland@arm.com,
atull@kernel.org, mdf@kernel.org, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
linux-fpga@vger.kernel.org, yves.vandervennet@linux.intel.com,
Richard Gong <richard.gong@intel.com>
Subject: Re: [PATCHv2 3/7] driver, misc: add Intel Stratix10 service layer driver
Date: Thu, 15 Mar 2018 17:48:36 +0100 [thread overview]
Message-ID: <20180315164836.GB4060@kroah.com> (raw)
In-Reply-To: <1519949975-13548-4-git-send-email-richard.gong@linux.intel.com>
On Thu, Mar 01, 2018 at 06:19:31PM -0600, richard.gong@linux.intel.com wrote:
> +EXPORT_SYMBOL_GPL(request_svc_channel_byname);
All of your global symbols should have the same prefix, not a verb. So
this should be:
svc_channel_request_by_name(), right?
> +EXPORT_SYMBOL_GPL(free_svc_channel);
svc_channel_free()?
> +EXPORT_SYMBOL_GPL(intel_svc_send);
Wait, why doesn't the first ones have "intel_svc" in them?
What is the difference here?
Should they all just have "intel_svc_" as the prefix?
Stick to one thing for all exported functions/variables please, it's the
only way we can attempt to keep our namespace "sane".
Also, why would a 'misc' driver be exporting things that something else
uses? Why not just put this in the fpga directory next to the users of
this code?
thanks,
greg k-h
next prev parent reply other threads:[~2018-03-15 16:48 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-02 0:19 [PATCHv2 0/7] Add Intel Stratix10 FPGA manager and service layer richard.gong
2018-03-02 0:19 ` [PATCHv2 1/7] dt-bindings, firmware: add Intel Stratix10 service layer binding richard.gong
2018-03-07 19:39 ` Rob Herring
2018-03-02 0:19 ` [PATCHv2 2/7] arm64: dts: stratix10: add service driver binding to base dtsi richard.gong
2018-03-02 0:19 ` [PATCHv2 3/7] driver, misc: add Intel Stratix10 service layer driver richard.gong
2018-03-15 16:48 ` Greg KH [this message]
2018-03-16 17:39 ` Richard Gong
2018-03-02 0:19 ` [PATCHv2 4/7] dt-bindings: fpga: add Stratix10 SoC FPGA manager binding richard.gong
2018-03-07 19:47 ` Rob Herring
2018-03-07 22:20 ` Alan Tull
2018-03-08 1:24 ` Rob Herring
2018-03-08 15:32 ` Alan Tull
2018-03-08 22:27 ` Rob Herring
2018-03-02 0:19 ` [PATCHv2 5/7] arm64: dts: stratix10: add fpga manager and region richard.gong
2018-03-02 0:19 ` [PATCHv2 6/7] fpga: add intel stratix10 soc fpga manager driver richard.gong
2018-03-02 0:19 ` [PATCHv2 7/7] defconfig: enable fpga and service layer richard.gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180315164836.GB4060@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=atull@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fpga@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mdf@kernel.org \
--cc=richard.gong@intel.com \
--cc=richard.gong@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=will.deacon@arm.com \
--cc=yves.vandervennet@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome