From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752524AbeCOSfL (ORCPT ); Thu, 15 Mar 2018 14:35:11 -0400 Received: from mx2.suse.de ([195.135.220.15]:42199 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbeCOSfJ (ORCPT ); Thu, 15 Mar 2018 14:35:09 -0400 Date: Thu, 15 Mar 2018 19:35:06 +0100 From: Michal Hocko To: Linus Torvalds Cc: Ard Biesheuvel , Daniel Vacek , linux-arm-kernel , open list , Mark Rutland , Will Deacon , Catalin Marinas , Marc Zyngier , Mel Gorman , Paul Burton , Pavel Tatashin , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH v2] Revert "mm/page_alloc: fix memmap_init_zone pageblock alignment" Message-ID: <20180315183506.GT23100@dhcp22.suse.cz> References: <20180315182110.GR23100@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu 15-03-18 11:28:27, Linus Torvalds wrote: > On Thu, Mar 15, 2018 at 11:21 AM, Michal Hocko wrote: > > > > Well, pfn_valid says that a given pfn is backed by a real memory and it > > has a valid struct page backing it. > > No, it really just says the latter. There should be a "struct page" for it. You are right! A simple example could be non volatile memory. That is certainly not RAM but it has pfn_valid memory. Sorry about the confusion. -- Michal Hocko SUSE Labs